Closed Bug 1222659 Opened 6 years ago Closed 6 years ago

Ensure conversation is MUC when attempting a subject change

Categories

(Chat Core :: XMPP, defect)

Product:
Chat Core
Component:
XMPP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Instantbird 45

People

(Reporter: arlolra, Assigned: arlolra)

Details

Attachments

(1 file)

ismuc.patch
3.38 KB, patch
aleth
: review+
Details | Diff | Splinter Review
Attached patch ismuc.patch — — Splinter Review 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.85 Safari/537.36

Steps to reproduce:

Received a stanza with a subject and body is a conversation that wasn't a chat.

https://trac.torproject.org/projects/tor/ticket/17552#comment:5


Actual results:

muc undefined threw


Expected results:

subject ignored and body parsed
Attachment #8684499 - Attachment is patch: true
Attachment #8684499 - Attachment mime type: text/x-patch → text/plain
Attachment #8684499 - Flags: review?(clokep)
Attachment #8684499 - Flags: review?(aleth)
Component: Conversation → XMPP
Product: Instantbird → Chat Core
cf. rfc6121 section 5.2.4.: "The <subject/> element contains human-readable XML character data that specifies the topic of the message."
Comment on attachment 8684499 [details] [diff] [review]
ismuc.patch

Review of attachment 8684499 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8684499 - Flags: review?(aleth) → review+
Comment on attachment 8684499 [details] [diff] [review]
ismuc.patch

Review of attachment 8684499 [details] [diff] [review]:
-----------------------------------------------------------------

aleth's review is fine, this doesn't also need my review.
Attachment #8684499 - Flags: review?(clokep)
https://hg.mozilla.org/comm-central/rev/370eb2c5f6748268d3eae5e892cbc8e71a3bf5ea
Bug 1222659 - Ensure XMPP conversation is a MUC before attempting a topic change. r=aleth
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 45
Assignee: nobody → arlolra
You need to log in before you can comment on or make changes to this bug.