122271 - Create editorTasksOverlay to allow optional inclusion of Composer button on the component bar

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Charles Manske]

Spin-off request from bug 89975:
> Moved all editor-related code out of XPFE and into editorApplicationOverlay.js,
> which is included via editorNavigatorOverlay.xul by the browser.

But not by other apps. This means that the editor button in the component bar is
broken unless the app happens to overlay editorNavigatorOverlay.xul or
editorMailOverlay.xul, i.e. only for browser and mail, but not e.g. ChatZilla.

Please either move NewEditorWindow() back to tasksOverlay.js, or (better) create
editorTasksOverlay.xul and editorTasksOverlay.js to resolve this, thus making it
easier to remove Editor.

Comment 1

[[e-mail]]

Attachment: Proposed editorTasksOverlay.xul

Comment 2

[[e-mail]]

Attachment: Changes to tasksOverlay.*

Comment 3

[Charles Manske]

I'll test this soon.

Comment 4

[[e-mail]]

Attachment: Wrong editorTasksOverlay.xul last time :-)

Comment 5

[[e-mail]]

Attachment: Tweak mailTasksOverlay.xul

This patch ensures that Composer appears in the correct place in the tasks menu
and component bar in case mailTasksOverlay.xul loads before
editorTasksOverlay.xul as I'm not sure if the load order can be guaranteed.

Comment 6

[Charles Manske]

This is Neil's work.

Comment 7

[[e-mail]]

Attachment: editorTasksOverlay.xul bitrotted

Comment 8

[[e-mail]]

Attachment: tasksOverlay.* bitrotted

Comment 9

[[e-mail]]

Attachment: mailTasksOverlay.xul bitrotted

Comment 10

[Charles Manske]

*** Bug 124366 has been marked as a duplicate of this bug. ***

Comment 11

[Charles Manske]

*** Bug 126281 has been marked as a duplicate of this bug. ***

Comment 12

[[e-mail]]

Attachment: Changes to contents.rdf

Sorry, I forgot to do these earlier.

Comment 13

[Charles Manske]

Problems I see with this:
1. In Browser and Mail windows, the Composer task icon is in the 1st position
2. You need to alter addressbook.xul and messengercompose.xul just as you did
for others.
3. When an existing Composer window is found, the focus doesn't propagate to
the editing content window -- must click in there to edit. (This probably isn't
your fault!)
4. Add editorTasksOverlay.xul to editor\jar.mn
5. The method toEditor() can simply be:
    function toEditor()
    {
      if (!CycleWindow("composer:html"))
        // Defined in editorApplicationOverlay.js
        NewEditorWindow();
    }
Anyone including editorTasksOverlay.xul should also have access to 
editorApplication.js. On this topic, maybe we should just have 
editorTasksOverlay.xul and .js and elliminate editorApplicationOveralay.js?
The latter isn't complete anyway: There are still "menu_newEditor" items in
other module XUL that should be added only via a Composer overlay.
And the New Blank page commands are still broken in history (bug 126281),
Addressbook, and JS Console windows. I think we should try to solve all of these
with one editor overlay set.

Comment 14

[[e-mail]]

Charles Manske wrote:

> Problems I see with this:
> 1. In Browser and Mail windows, the Composer task icon is in the 1st position

I don't see this. I can't even see how this would happen.

> 2. You need to alter addressbook.xul and messengercompose.xul just as you did
> for others.

I don't understand this comment. They use tasksOverlay, that's the point.

> 3. When an existing Composer window is found, the focus doesn't propagate to
> the editing content window -- must click in there to edit. (This probably
> isn't your fault!)

I don't know what happened before, sorry.

> 4. Add editorTasksOverlay.xul to editor\jar.mn

Is it just this file that's affected?

5. <snip>

I disagree. The point is that editorApplicationOverlay is only used to overlay
the browser and messenger, it has no relevance to the rest of Mozilla.

Comment 15

[Charles Manske]

changing milestone

Comment 16

[[e-mail]]

Attachment: Changes to editorApplicationOverlay.js

Really sorry for missing this one off, must have confused you somewhat!

Comment 17

[Charles Manske]

*** Bug 127036 has been marked as a duplicate of this bug. ***

Comment 18

[Charles Manske]

*** Bug 127523 has been marked as a duplicate of this bug. ***

Comment 19

[Charles Manske]

Comment on attachment 68520 [details]
editorTasksOverlay.xul bitrotted

r=cmanske

Comment 20

[Charles Manske]

Comment on attachment 68521 [details] [diff] [review]
tasksOverlay.* bitrotted

r=cmanske

Comment 21

[Charles Manske]

Comment on attachment 68522 [details] [diff] [review]
mailTasksOverlay.xul bitrotted

r=cmanske

Comment 22

[Charles Manske]

Comment on attachment 70531 [details] [diff] [review]
Changes to contents.rdf

r=cmanske

Comment 23

[Charles Manske]

Comment on attachment 70919 [details] [diff] [review]
Changes to editorApplicationOverlay.js

r=cmanske

Comment 24

[Joe Hewitt (gone)]

Comment on attachment 68520 [details]
editorTasksOverlay.xul bitrotted

sr=hewitt

Comment 25

[Joe Hewitt (gone)]

Comment on attachment 68521 [details] [diff] [review]
tasksOverlay.* bitrotted

sr=hewitt

Comment 26

[Joe Hewitt (gone)]

Comment on attachment 68522 [details] [diff] [review]
mailTasksOverlay.xul bitrotted

sr=hewitt

Comment 27

[Joe Hewitt (gone)]

Comment on attachment 70531 [details] [diff] [review]
Changes to contents.rdf

sr=hewitt

Comment 28

[Joe Hewitt (gone)]

Comment on attachment 70919 [details] [diff] [review]
Changes to editorApplicationOverlay.js

sr=hewitt

Comment 29

[Asa Dotzler [:asa]]

Comment on attachment 68520 [details]
editorTasksOverlay.xul bitrotted

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 30

[Asa Dotzler [:asa]]

Comment on attachment 68521 [details] [diff] [review]
tasksOverlay.* bitrotted

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 31

[Asa Dotzler [:asa]]

Comment on attachment 68522 [details] [diff] [review]
mailTasksOverlay.xul bitrotted

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 32

[Asa Dotzler [:asa]]

Comment on attachment 70531 [details] [diff] [review]
Changes to contents.rdf

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 33

[Asa Dotzler [:asa]]

Comment on attachment 70919 [details] [diff] [review]
Changes to editorApplicationOverlay.js

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 34

[Charles Manske]

checked in

Comment 35

[[e-mail]]

Attachment: Preventative measure

I have been able to break my build of Mozilla by manually editing some internal
configuration files, and I am worried that normal use of Mozilla may reproduce
my edits, which would break the tasks menu. However this patch prevents that.

Comment 36

[sujay]

Charley, please verify this bug...thanks

Comment 37

[Charles Manske]

Reopened to work on issue Neil found with overlay load order.

Comment 38

[sujay]

verification instructions per cmanske = verify New Blank Page works from all
modules.

Comment 39

[sujay]

also test that the icons for each moduel on the taskbar appear in the correct
order.

Comment 40

[Charles Manske]

Comment on attachment 75958 [details] [diff] [review]
Preventative measure

r=cmanske
This controls order of overlay loading so editorTasksOverlay is always loaded
before mailTaskOverlay

Comment 41

[Charles Manske]

I'm going to mark this fixed. The new patch addresses problem reported 
separately in bug 133167 and is moved there.

Comment 42

[sujay]

verified in 3/26 build.

REOPEN if anyone disagrees.