Closed Bug 1222792 Opened 4 years ago Closed 4 years ago

Refresh loop on pinned website that was in Reader View, after Firefox restart

Categories

(Toolkit :: Reader Mode, defect)

42 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox42 --- wontfix
firefox43 --- wontfix
firefox44 - fixed
firefox45 + fixed
firefox46 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jack.gurulian, Assigned: Gijs, NeedInfo)

References

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151102093730

Steps to reproduce:

I put a pinned website in Reader View and restarted Firefox


Actual results:

After restarting the browser, the pinned page keeps refreshing until I close it. I also cannot refresh it or exit the Reader View.


Expected results:

Either not fall in a refresh loop or, after restart, the webpage to be on normal mode instead of Reader View.
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Component: Untriaged → Tabbed Browser
WFM on Fx43 Win10.
Test page: https://blog.mozilla.org/addons/2015/11/20/signing-api-now-available/


Could you try Firefox without add-ons?
Flags: needinfo?(jack.gurulian)
I tried it with that website but does not occur even with add-ons enabled. This website caused the problem to me: http://pitsirikos.net/2012/10/%CF%80%CF%8E%CF%82-%CF%83%CF%84%CF%81%CF%8E%CE%B8%CE%B7%CE%BA%CE%B5-%CE%BF-%CE%B4%CF%81%CF%8C%CE%BC%CE%BF%CF%82-%CE%B3%CE%B9%CE%B1-%CF%84%CE%BF%CE%BD-%CF%86%CE%B1%CF%83%CE%B9%CF%83%CE%BC%CF%8C/

I can reproduce it with or without add-ons enabled.
Flags: needinfo?(jack.gurulian)
43 is shipping this week, RC builds have been built already, and this isn't going to block it shipping. I also seem to recall this is a duplicate, but I can't find it offhand. Going to leave needinfo and hopefully find time to look at this tomorrow.
See Also: → 1225448
Bug 1222792 - fix comparing escaped URIs in reader mode when detecting redirects, r?margaret
Attachment #8698456 - Flags: review?(margaret.leibovic)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
OS: Linux → All
Hardware: x86_64 → All
See Also: 1225448
Duplicate of this bug: 1225448
Comment on attachment 8698456 [details]
MozReview Request: Bug 1222792 - fix comparing escaped URIs in reader mode when detecting redirects, r?margaret

mm, mozreview is being wonky (bug 1232287) so manually carrying r+.
Attachment #8698456 - Flags: review?(margaret.leibovic) → review+
https://hg.mozilla.org/mozilla-central/rev/ed92012dbd5c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8698456 [details]
MozReview Request: Bug 1222792 - fix comparing escaped URIs in reader mode when detecting redirects, r?margaret

Approval Request Comment
[Feature/regressing bug #]: bug 1195976
[User impact if declined]: some pages go into an infinite redirect loop if you try to view them in reader mode
[Describe test coverage new/current, TreeHerder]: sadly, the test coverage here is pretty limited - but there is some core automated testing that would have failed if this broke reader mode completely
[Risks and why]: very low, essentially making sure URL redirection code deals with escaping better than it did
[String/UUID change made/needed]: no
Attachment #8698456 - Flags: approval-mozilla-beta?
Attachment #8698456 - Flags: approval-mozilla-aurora?
lakovos, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(jack.gurulian)
I don't feel the need to track it. Will uplift to Beta44 soon anyway.
Comment on attachment 8698456 [details]
MozReview Request: Bug 1222792 - fix comparing escaped URIs in reader mode when detecting redirects, r?margaret

Seems safe to uplift to Beta44 and Aurora45.
Attachment #8698456 - Flags: approval-mozilla-beta?
Attachment #8698456 - Flags: approval-mozilla-beta+
Attachment #8698456 - Flags: approval-mozilla-aurora?
Attachment #8698456 - Flags: approval-mozilla-aurora+
Depends on: 1263628
You need to log in before you can comment on or make changes to this bug.