1222802 - marketplace 'visit top site' widget issue

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[Ram Dayal Vaishnav [:ram]]

User-Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

As per attached screenshot, 'Visit the top site' widget it shows three sites icon and describes one of them in bottom. But the arrow to connect which sites description is given is missing.

Comment 1

[Ram Dayal Vaishnav [:ram]]

Attachment: 2015-11-08-19-32-26.png

Comment 2

[Mahendra Potharaju [:mahe]]

David, Can you please look at this bug? Thanks

Comment 3

[David Durst [:ddurst]]

Good catch. This is a regression from the original design: https://drive.google.com/a/mozilla.com/file/d/0B3KnWfn_4CqGY0tkbWJ3OFFfbGs/view?usp=sharing

Comment 4

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/commit/ba59557

Comment 5

[Enrico]

I still see this happening. Has the patch already landed on Marketplace? Should this bug be reopened?

Comment 6

[David Durst [:ddurst]]

I don't see it anymore. You might need to flush your cache.

Comment 7

[Enrico]

I really keep seeing that, and other Foxfooders can reproduce it too. Flushing the cache didn't help. Could you please double-check?

Comment 8

[David Durst [:ddurst]]

This is verified fixed on 2.2 and 2.5 at least.

Can you give us more info about your device and STR?

Comment 9

[Davor Spasovski [:spasovski]]

I get this: http://i.imgur.com/OQhVgZN.png do you mind posting more info on FFOS version number, site visited.

Does it also reproduce on our staging environment? https://marketplace.allizom.org

Comment 10

[Enrico]

I'm using a Flame with 2.6, platform 46.0a1, build Id 20151222030233 (that is, last build sent on the nightly-latest channel). I can reproduce on the Marketplace app, but not on the staging environment https://marketplace.allizom.org as the widget doesn't show up there.

The issue presents itself only for the second and third sites on the widget. I'll add a screenshot.

Comment 11

[Enrico]

Attachment: 2015-12-22-19-18-49.png

Comment 12

[Enrico]

Attachment: 2015-12-22-19-18-55.png

Comment 13

[Davor Spasovski [:spasovski]]

Yes the issue now shows up on the other 2 tabs (this was definitely tested so something else must've regressed it). I'll reopen and have a look.

Comment 14

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/fireplace/commit/9417dbe