1222867 - micro-optimize reference-counting for WebSocketFrame objects

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: part 1 - return already_AddRefed from WebSocketEventService::CreateFrameIfNeeded

The result of CreateFrameIfNeeded is always assigned to a RefPtr, so we
can save a little code space by moving the AddRef into the callee,
rather than doing it in the caller.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: part 2 - be smarter about transferring ownership of WebSocketFrame

WebSocketFrames are created only to be transferred in to
WebSocketEventService::Frame{Sent,Received}, where a strong reference is
taken to them by a runnable posted to the main thread.  Let's avoid an
extra AddRef/Release cycle by passing through already_AddRefed
structures.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a96097c7f612
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d6c2b2974e9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a96097c7f612
https://hg.mozilla.org/mozilla-central/rev/2d6c2b2974e9