[Telephony][CDMA] Support to Voice Privacy indicator

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
3 years ago
11 months ago

People

(Reporter: bhsu, Unassigned)

Tracking

unspecified
FxOS-S12 (27Nov)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(feature-b2g:2.2r+)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
In a CDMA network, there is an indicator of every telephony call showing whether the call is a voice private call. Now, we are going to expose this information as a property of Telephony WebAPIs. Besides, the value of the indicator can be changed during its lifetime, so a correspondeing event is also needed.

From above statement, there are two things should be done for this bug. One is to add a new property named |private| to TelephonyCall.webidl, while the other is to design an event to notify the change of |private|. Since there are already too many events in Telephony WebAPIs, which make the sequence of events hard to maintain, we are going to reuse |onstatechange| for the change of |private|. Per previous discussing, this approach fits current dialer code.
(Reporter)

Updated

3 years ago
See Also: → bug 1211806
(Reporter)

Comment 1

3 years ago
Hi Wesley,

Can you help mark feature-b2g to 2.2r+? Thanks!
Flags: needinfo?(whuang)
Target Milestone: --- → FxOS-S12 (27Nov)
feature-b2g: --- → 2.2r+
Flags: needinfo?(whuang)
(Reporter)

Updated

3 years ago
Assignee: nobody → bhsu
(Reporter)

Comment 2

3 years ago
Created attachment 8684808 [details] [diff] [review]
Part 1: Add |private| to TelephonyCall and launch onstatechange when |private| changes (DOM)

After applying this patch, |onstatechange| is also launched when the |private| property changes. However, there will be two |onstatechange| events launched when the |private| property and the call state change in the same time, where the first is for the change of |private| and the other is for the change of call state.
(Reporter)

Comment 3

3 years ago
Created attachment 8684809 [details] [diff] [review]
Part 2:Internal implemention changes
(Reporter)

Comment 4

3 years ago
Created attachment 8684810 [details] [diff] [review]
Part 2: Internal implemention changes
Attachment #8684809 - Attachment is obsolete: true
(Reporter)

Comment 5

3 years ago
Created attachment 8684811 [details] [diff] [review]
Part 3: Enhance head.js (Test)
(Reporter)

Comment 6

3 years ago
Created attachment 8684813 [details]
An extra testcase

This patch is am extra testcase for this issue. However, since messages are directly send to Telephony Service from the testcase in addition to RadioInterfaceLayer, the two clients of Telephony Service might interfere each other, and thus this testcase can be unstable. As a result, this testcase is uploaded here as a handy tool, and shouldn't be landed into the code base.
(Reporter)

Updated

3 years ago
Attachment #8684808 - Flags: review?(htsai)
Attachment #8684808 - Flags: review?(btseng)
(Reporter)

Updated

3 years ago
Attachment #8684810 - Flags: review?(btseng)
(Reporter)

Updated

3 years ago
Attachment #8684811 - Flags: review?(btseng)
Comment on attachment 8684808 [details] [diff] [review]
Part 1: Add |private| to TelephonyCall and launch onstatechange when |private| changes (DOM)

Review of attachment 8684808 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you!
Attachment #8684808 - Flags: review?(btseng) → review+
Comment on attachment 8684810 [details] [diff] [review]
Part 2: Internal implemention changes

Review of attachment 8684810 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you!
Attachment #8684810 - Flags: review?(btseng) → review+
Comment on attachment 8684811 [details] [diff] [review]
Part 3: Enhance head.js (Test)

Review of attachment 8684811 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #8684811 - Flags: review?(btseng) → review+
Attachment #8684808 - Flags: review?(htsai) → review+
(Reporter)

Updated

3 years ago
Assignee: bhsu → nobody

Comment 10

11 months ago
Firefox OS is not being worked on
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.