1222920 - Add support of REQUEST_DEVICE_IDENTITY

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

In bug 1222870, we are going to expose Mobile Device Identities including IMEI, IMEISV for GSM and ESN, MEID for CDMA.

File this bug to have the support of REQUEST_DEVICE_IDENTITY to ensure the test coverage in bug 1222870.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (ics) Patch: Add support of REQUEST_DEVICE_IDENTITY. r=echen

Hi Edgar,

May I have your review for this change?
Here is the try server result for your reference:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5ede9394a6f&exclusion_profile=false

Thanks!

Comment 2

[Edgar Chen [:edgar]]

Comment on attachment 8685768 [details] [review]
(ics) Patch: Add support of REQUEST_DEVICE_IDENTITY. r=echen

r=me with comments on github addressed. Thank you.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Comment on attachment 8685768 [details] [review]
(ics) Patch: Add support of REQUEST_DEVICE_IDENTITY. r=echen

address comment 2.

Comment 4

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (kk) Patch: Add support of REQUEST_DEVICE_IDENTITY. r=echen

add git pull request for kk

Comment 5

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/platform_hardware_ril/commit/cb4604d5a578efd027277059ce3e0f6e3af59bd1
https://github.com/mozilla-b2g/platform_hardware_ril/commit/29cbaa03a380ab69d47c476dd433059f7680837c

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v2.2) Patch: Add support of REQUEST_DEVICE_IDENTITY. r=echen

Hi Edgar,

Would you mind uplifting this pull request to v2.2 branch?

Thanks!

Comment 7

[Edgar Chen [:edgar]]

v2.2:
https://github.com/mozilla-b2g/platform_hardware_ril/commit/828822fef9ec3f6711ee0770c50b8268a74a8fb7