Closed Bug 1223035 Opened 9 years ago Closed 9 years ago

move output-parser.js to devtools/client/shared

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: tromey, Assigned: tromey)

Details

Attachments

(1 file, 2 obsolete files)

move output-parser.js to devtools/client/shared
6.22 KB, patch
tromey
: review+
Details | Diff | Splinter Review 
output-parser.js is in devtools/shared, but it doesn't make sense to
use it outside of the client; so it should be in devtools/client/shared
Attachment #8684957 - Flags: review?(jryans)
Comment on attachment 8684957 [details] [diff] [review]
move output-parser.js to devtools/client/shared

Review of attachment 8684957 [details] [diff] [review]:
-----------------------------------------------------------------

Yay, one less file in the server.  Thanks for doing this!
Attachment #8684957 - Flags: review?(jryans) → review+
Keywords: checkin-needed
Hi, this fails to apply:

renamed 1223035 -> Bug-1223035---move-output-parserjs-to-devtoolsclie.patch
applying Bug-1223035---move-output-parserjs-to-devtoolsclie.patch
patching file devtools/client/styleinspector/rule-view.js
Hunk #1 FAILED at 9
1 out of 1 hunks FAILED -- saving rejects to file devtools/client/styleinspector/rule-view.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1223035---move-output-parserjs-to-devtoolsclie.patch
Flags: needinfo?(ttromey)
Keywords: checkin-needed
Rebased.
Flags: needinfo?(ttromey)
Attachment #8685434 - Flags: review+
Keywords: checkin-needed
hm this needs rebased again i think

renamed 1223035 -> Bug-1223035---move-output-parserjs-to-devtoolsclie.patch
applying Bug-1223035---move-output-parserjs-to-devtoolsclie.patch
patching file devtools/client/shared/test/browser_outputparser.js
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file devtools/client/shared/test/browser_outputparser.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1223035---move-output-parserjs-to-devtoolsclie.patch
Tomcats-MacBook-Pro-2:fx-team Tomcat$
Flags: needinfo?(ttromey)
Keywords: checkin-needed
Rebased.
Attachment #8684957 - Attachment is obsolete: true
Attachment #8685434 - Attachment is obsolete: true
Flags: needinfo?(ttromey)
Attachment #8686122 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b4d21d6aad0a
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: