122307 - FTP does not work if memory and disk cache sizes are zero

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect, P1)

Description

[Simon Fraser [no longer active]]

If you set both memory and disk cache to zero, quit and restart the browser, and 
they try to do FTP, it fails to show any FTP results. FTP just doesn't work at 
all.

I didn't try different memory/disk cache settings.

Comment 1

[Doug Turner (:dougt)]

that is not good.  It use to work.  We need to fix this.  Bradley, can you look
at this soon.  If not, punt to me.

Comment 2

[Simon Fraser [no longer active]]

It seems that both memory and disk cache sizes need to be 0 to see this.

Comment 3

[Bradley Baetz (:bbaetz)]

I appear to have local changes which accidentally disable the cache (oops)

I'll play with this tomorrow. Looking at code, I think I just need to ignore
errors from AsyncOpenCacheEntry. Thats what http does, at least...

Comment 4

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 5

[Darin Fisher]

Comment on attachment 67052 [details] [diff] [review]
patch

sr=darin, one day you might want to modify FTP to use OpenCacheEntry followed
by AsyncOpenCacheEntry only if the cache entry is busy.

Comment 6

[Bradley Baetz (:bbaetz)]

Checked in. darin, I'll do that as part of some other bugs I have on fixing up
the cache flags, possibly.

Comment 7

[benc]

simon: is this working for you now?

Comment 8

[benc]

VERIFIED: Mozilla 1.1, Mac OS X.

I'll check the other plats when I run my ftp functional tests w/ caches off.

Comment 9

[benc]

VERIFIED: win and linux, Mozilla 1.4b