1223129 - Copy action puts both title and url on the pasteboard

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This title of this bug is probably a bit misleading because I don't think this is a pasteboard thing but instead an NSExtensionItem issue -- the data we pass to the Share Sheet.

STR:

1. Go to a page with a proper title
2. Select Copy from the share menu
3. Go to Safari.app
4. Paste into the location bar

Expected: just the URL
Actual: The Title + URL


Safari does this correctly. We should follow what it does.

Note that this is a bit trickier than just removing the title from the data we share.

The title Must be in that data because other apps depend on it. For example when you share something to Twitter, the title is taken as the tweet text and the url is used as an attached link.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I think this is important enough to ship in 1.2 is possible.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1241

This patch introduces a `TitleActivityItemProvider`. This UIActivityItemProvider subclass does two things that are non-standard behaviour:

* We return `NSNull` if the calling activity is not supposed to see the title. For example the *Copy* action, which should only paste the URL. We also include *Message* and *Mail* to have parity with what Safari exposes.
* We set the subject of the item to the title, this means it will correctly be used when sharing to for example Mail. Again parity with Safari.

Note that not all applications use the Subject. For example *OmniFocus* ignores it, so we need to do both.

Tested with the following share extensions: Firefox, Message, Mail, Pocket, Reminder, Notes, OmniFocus, Mail, Twitter, Evernote.

Tested with the following action extensions: Copy, Print, Send Tab, View Later.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8685591 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1241

LGTM and works pretty well

Comment 4

[Nick Nguyen [:osunick]]

\o/

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8685591 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1241

LGTM.