1223145 - homepage_url should be displayed in about:addons

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Adrian Aichner [:anaran]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151018052213

Steps to reproduce:

Add homepage_url field to local git clone of
https://github.com/mdn/webextensions-examples/tree/master/beastify

Build with
/var/tmp/webextensions-examples/beastify$ zip -r ../beastify.xpi *
and install that
beastify.xpi



Actual results:

The homepage_url is nowhere to be seen in about:addons


Expected results:

Just like the jetpack add-on homepage field from package.json is displayed in about:addons, so should homepage_url.

See https://developer.chrome.com/extensions/manifest/homepage_url

Comment 1

[Andy McKay]

Oh I didn't know that existed. We should do this, but I don't think its a blocking bug.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

It looks like we'll need to change the code at https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIProvider.jsm#918 to use the homepage_url from the manifest, with a call to getProp("homepage_url")…

Adrian, would you like to try fixing this one?

Comment 3

[Adrian Aichner [:anaran]]

Looking at
https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/internal/XPIProvider.jsm#918
I would suggest to handle the other null fields as well.

I am currently not set up to build Firefox since I moved from Windows XP to Ubuntu.

It can hardly be the editing of the file you want help with.

What would be the major chunk of work involved?

Comment 4

[Blake Winton (:bwinton) (:☕️)]

I don't think we need to handle most of the other null fields, at least not in this bug, although if you felt like it, I suspect that fix would be accepted.  And yes, it is the editing of the file (and making sure the tests run and the code passes review) I'ld like help with.  It's not that I couldn't make the change, it's more that I'm trying to do a million other things, and if someone can do this instead of me, that frees me up to work on other stuff.  :)

Also, since you reported the bug, I think you probably have a better idea of what other fields should be added than the rest of us…

Comment 5

[Adrian Aichner [:anaran]]

Here's my change, tested in my debugger in 45.0a1 (2015-11-27)

https://github.com/anaran/gecko-dev/commit/87f7d53e982460d5d752a49217f9d666a15492a2

I did this one online on github, so no patch (yet).

Comment 6

[Adrian Aichner [:anaran]]

Attachment: github raw patch

Comment 7

[Adrian Aichner [:anaran]]

Attachment: github raw patch

Comment 8

[Adrian Aichner [:anaran]]

I was able to see the homepage URL show up under about:addons.

Clicking on it opens a new tab for that URL.

I used a build[1] in directory
https://github.com/anaran/webextensions-examples/tree/Issue_16/notify-link-clicks
to test a manifest with a homepage_url

and
https://github.com/anaran/webextensions-examples/tree/communicate/communicate
to test a manifest without a homepage_url

Both cases worked in the debugger.

[1] zip -r ../$(basename $(pwd)).xpi *

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8693046 [details] [diff] [review]
github raw patch

I think this will be okay, but I'm redirecting to Mossop for the actual review.
I also suspect we'll want to add some tests, but I'm not sure where to put those.

Comment 10

[Dave Townsend [:mossop]]

Comment on attachment 8693046 [details] [diff] [review]
github raw patch

Review of attachment 8693046 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I'd sure love to see this added to the tests though.

Comment 11

[Andy McKay]

Any chance to work on tests :anaran, so we can merge?

Comment 12

[Adrian Aichner [:anaran]]

I don't see myself working on the tests in the near future.

Being a mozilla contributor has become more and more of a drag after investing in a number of mozilla-dead-ends:

cfx, jpm, jetpack (AKA add-on SDK), Firefox OS, DOM:Apps, Thunderbird.

I'll go mozilla-agnostic for a while and migrate to technologies which will still work should mozilla drop firefox or whatever (service worker, chrome extensions, etc.).

Comment 13

[Andy McKay]

Looks like kmag got this in https://hg.mozilla.org/mozilla-central/diff/4c924e5c2749/toolkit/mozapps/extensions/internal/XPIProvider.jsm#l909

Comment 14

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial issue on Firefox 44.0a1 (2015-10-21) under Windows 10 64-bit.

Verified fixed on Firefox 48.0a1 (2016-03-27) under Windows 10 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.11. The homepage url is successfully displayed in about:addons.

Comment 15

[Tomislav Jovanovic :zombie]

Not sure why this would need dev docs, or even where those would go.