Closed Bug 1223150 Opened 6 years ago Closed 5 years ago

Set dir attribute on body element for all HTML pages in devtools aka make 'Force RTL' work with devtools

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: bgrins, Unassigned)

References

(Blocks 1 open bug)

Details

The :-moz-dir() selector doesn't work unless if the 'dir' attribute is set on an element in html (usually <body>).  So we don't have a good way to do RTL fixes for devtools for most tools (which aren't setting dir).

The layout view does something fancy where it sets 'dir' in js when the page loads: https://dxr.mozilla.org/mozilla-central/source/devtools/client/layoutview/view.js#580.

aboutNetError does some dtd stuff to do dir="&locale.dir": https://dxr.mozilla.org/mozilla-central/source/browser/base/content/aboutNetError.xhtml#399.

We could either do something like this in theme-switching.js so all html pages get dir="" automatically, or use dtd stuff individually for each frame.

I'm leaning towards theme-switching.js since it's already loaded in all frames and it would automatically work without extra stuff in each page.  It relies on some chrome stuff which is a consideration for addon panels, but so does some other theme-switching things right now.
Seems fixed now. jdescottes introduced a solution that automatically sets the dir attribute from the toolbox if you have dir="" on the panel doc.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.