Closed Bug 1223169 Opened 5 years ago Closed 5 years ago

Skip the top of the stack for CrashStatsLogForwarder::CrashAction

Categories

(Socorro :: General, task)

Unspecified
All
task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: milan, Unassigned)

Details

https://crash-stats.mozilla.com/report/index/f2e7a15d-f5e2-41d9-a865-c589d2151109 should show up as a crash with CompositorD3D11::HandleError signature, with the rest of the items at the top of the stack ignored (CrashStatsLogForwarder::CrashAction is a new item)
Anthony, KaiRo - until this gets closed, some of the CompositorD3D11::HandleError bugs will end up in CrashStatsLogForwarder::CrashAction instead.  Once bug 1219494 lands, there will be even more things that end up in that CrashAction method.
Bug 1219494 is about to land, do we have an idea as to the approximate timeframe for taking care of this?
Lars, we need to add CrashStatsLogForwarder::CrashAction to the prefix skiplist, can you do that?
Assignee: server-ops-webops → nobody
Component: WebOps: Socorro → General
Flags: needinfo?(lars)
Product: Infrastructure & Operations → Socorro
QA Contact: smani
:kairo, adding "CrashStatsLogForwarder::CrashAction" signature to the prefix list will not generate the signature requested in Comment #0.  Adding it to prefix list would generate "CrashStatsLogForwarder::CrashAction | mozilla::gfx::Log<T>::WriteLog"    

If "CrashStatsLogForwarder::CrashAction.*" and "mozilla::gfx::Log.*" were added to the ignore list then, the signature would be "mozilla::layers::CompositorD3D11::HandleError".  If the desired signature is really just "CompositorD3D11::HandleError" then we'll have to write a new rule for that just signature to truncate the "mozilla::layers::" namespaces.  

what do you want done?
Flags: needinfo?(lars)
The question is really what the gfx team needs there. Milan?
Flags: needinfo?(milan)
mozilla::layers::CompositorD3D11::HandleError would be great, so it sounds like we'd want "CrashStatsLogForwarder::CrashAction.*" and "mozilla::gfx::Log.*" in the prefix list?
Flags: needinfo?(milan)
For example, this report: https://crash-stats.mozilla.com/report/index/7905b94a-c177-4f6a-8c6b-5a3db2160112 should then show up as:

xul.dll 	mozilla::layers::LockD3DTexture<ID3D11Texture2D> 	gfx/layers/d3d11/TextureD3D11.cpp
xul.dll 	mozilla::layers::DXGITextureHostD3D11::Lock() 	gfx/layers/d3d11/TextureD3D11.cpp
xul.dll 	mozilla::layers::ImageHost::Lock() 	gfx/layers/composite/ImageHost.cpp

instead, and probably get a new bug, rather than hiding under the generic one.
Flags: needinfo?(lars)
Flags: needinfo?(kairo)
Well, we can't change the stack, only the signature. So you are saying you want the CrashStatsLogForwarder::CrashAction and mozilla::gfx::Log.* frames to be completely removed from the signatures?
That would be great!
OK, then this is up for implementation that way - sounds like we should add both CrashStatsLogForwarder::CrashAction and mozilla::gfx::Log.* to the actual ignore skiplist.

Created a PR in https://github.com/mozilla/socorro/pull/3176 that should achieve this.
Flags: needinfo?(lars)
Flags: needinfo?(kairo)
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/77be35a7750caab8872e09a220f0c5484d10c0fd
Fixes bug 1223169, add CrashStatsLogForwarder::CrashAction and mozilla::gfx::Log to the ignore skiplist

https://github.com/mozilla/socorro/commit/790c14520f0788ee30aa00ffccaabe6d0b735a11
Merge pull request #3176 from KaiRo-at/master

bug 1223169 - ignore skiplist additions for gfx error logging
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.