Closed Bug 1223228 Opened 4 years ago Closed 4 years ago

remove unused nsFrameManagerBase::mStyleSet

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

nsFrameManagerBase::mStyleSet is unused and can be removed.
Attached patch patchSplinter Review
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8685184 - Flags: review?(dholbert)
Comment on attachment 8685184 [details] [diff] [review]
patch

Review of attachment 8685184 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me, just one nit:

::: layout/base/nsCSSFrameConstructor.h
@@ +54,5 @@
>    typedef mozilla::dom::Element Element;
>  
>    friend class mozilla::RestyleManager;
>  
> +  nsCSSFrameConstructor(nsIDocument *aDocument, nsIPresShell* aPresShell);

While you're here, let's bump the "*" to the left in "nsIDocument *aDocument" here.

(You did this cleanup in the constructor's definition in the .cpp file, but not here in the declaration in the .h file. Might as well keep 'em consistent.)
Attachment #8685184 - Flags: review?(dholbert) → review+
Comment on attachment 8685184 [details] [diff] [review]
patch

Review of attachment 8685184 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsFrameManager.h
@@ +81,5 @@
>  {
>    typedef mozilla::layout::FrameChildListID ChildListID;
>  
>  public:
> +  nsFrameManager(nsIPresShell* aPresShell) {

Oh, this also needs to now become...
 MOZ_IMPLICIT nsFrameManager(nsIPresShell* aPresShell) {

...now that it's a 1-arg constructor.  (or else you'll trip a static analysis error)
er, s/MOZ_IMPLICIT/explicit/ of course (we don't want this to be an implicit conversion constructor)

(I was remembering MOZ_EXPLICIT, but couldn't find it with MXR, because it was recently renamed; and I mistakenly found MOZ_IMPLICIT)
https://hg.mozilla.org/mozilla-central/rev/98e376356227
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.