1223228 - remove unused nsFrameManagerBase::mStyleSet

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Cameron McCormack (:heycam)]

nsFrameManagerBase::mStyleSet is unused and can be removed.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8685184 [details] [diff] [review]
patch

Review of attachment 8685184 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me, just one nit:

::: layout/base/nsCSSFrameConstructor.h
@@ +54,5 @@
>    typedef mozilla::dom::Element Element;
>  
>    friend class mozilla::RestyleManager;
>  
> +  nsCSSFrameConstructor(nsIDocument *aDocument, nsIPresShell* aPresShell);

While you're here, let's bump the "*" to the left in "nsIDocument *aDocument" here.

(You did this cleanup in the constructor's definition in the .cpp file, but not here in the declaration in the .h file. Might as well keep 'em consistent.)

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8685184 [details] [diff] [review]
patch

Review of attachment 8685184 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsFrameManager.h
@@ +81,5 @@
>  {
>    typedef mozilla::layout::FrameChildListID ChildListID;
>  
>  public:
> +  nsFrameManager(nsIPresShell* aPresShell) {

Oh, this also needs to now become...
 MOZ_IMPLICIT nsFrameManager(nsIPresShell* aPresShell) {

...now that it's a 1-arg constructor.  (or else you'll trip a static analysis error)

Comment 4

[Daniel Holbert [:dholbert]]

er, s/MOZ_IMPLICIT/explicit/ of course (we don't want this to be an explicit constructor)

(I was remembering MOZ_EXPLICIT, but couldn't find it with MXR, because it was recently renamed; and I mistakenly found MOZ_IMPLICIT)

Comment 5

[Daniel Holbert [:dholbert]]

er, s/MOZ_IMPLICIT/explicit/ of course (we don't want this to be an implicit conversion constructor)

(I was remembering MOZ_EXPLICIT, but couldn't find it with MXR, because it was recently renamed; and I mistakenly found MOZ_IMPLICIT)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98e376356227

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98e376356227