Closed
Bug 1223237
Opened 10 years ago
Closed 10 years ago
Screenshots disappear after restoring multiple times
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 1.2+ | --- |
People
(Reporter: bnicholson, Assigned: bnicholson)
Details
Attachments
(1 file)
STR: Open some tabs, close and reopen the browser. Close and reopen again. All the tabs are missing their screenshots.
This happens because of the following call chain:
restoreTabs -> selectTab -> preserveTabs -> imageStore?.clearExcluding()
clearExcluding purges the image store of unused screenshots, but it happens right when we restore tabs on startup, meaning we clear them before we ever read them.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8685198 -
Flags: review?(sleroux)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8685198 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1236
LGTM - much cleaner with the restoration state in the TabManager
Attachment #8685198 -
Flags: review?(sleroux) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•