Closed Bug 1223273 Opened 9 years ago Closed 8 years ago

[TV][Browser] Revise i10n string of fxa offline error message

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)

ARM
Gonk (Firefox OS)
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

VERIFIED FIXED
blocking-b2g 2.5+
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: cynthiatang, Assigned: danhuang)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

Commit 23cab7ea0fcecab7689d340baf604e024e88f9a3
Merge: 31b9443 b5d36f9
Author: gasolin <gasolin@gmail.com>
Date:   Mon Nov 9 14:13:17 2015 +0800

Case 1:
 1. Launch Browser
 2. Move cursor to Menu icon and press OK 
 3. Disconnect the network
 4. Select "Sign in to Sync" and press OK

Actual Result:
 - It shows "No network connection. You need to be online to use Firefox Sync."

Case 2:
 1. Launch Browser
 2. Move cursor to Menu icon and press OK 
 3. Select "Sign in to Sync" and press OK
 4. Disconnect the network
 5. Enter your Firefox account and press OK

Actual Result:
 -  It shows "Unable to Connect. Please connect to a network from Settings."
Hi Tori,
Do we need the different dialog boxes when the network is disconnected? Thank you!
QA Whiteboard: [COM=TV Firefox Account]
Flags: needinfo?(tchen)
Summary: [TV Browser] Would be nice to have the same dialog box for disconnecting the network → [TV Browser] Would be nice to have the same dialog box when the network is disconnected
Hi Cynthia, 
Please use this one, thank you!

Unable to Connect. Please connect to a network from Settings.
Flags: needinfo?(tchen)
Priority: P3 → P2
Summary: [TV Browser] Would be nice to have the same dialog box when the network is disconnected → [TV][Browser][New Strings] Would be nice to have the same dialog box when the network is disconnected
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick]
Blocks: 1223379
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
Blocks: 1227036
blocking-b2g: --- → 2.5+
I feel it's not a blocker. Showing different messages in different case makes sense to me. @Tori, do you think it hurts user experience? Could we fix this afterward? (i.e. not in 2.5)

set it back to 2.5? and ni Josh to get his attention.
blocking-b2g: 2.5+ → 2.5?
Flags: needinfo?(tchen)
Flags: needinfo?(jocheng)
From UX perspective it's not essential for 2.5 so I'll let Josh make the decision.
Flags: needinfo?(tchen)
blocking-b2g: 2.5? → 2.5+
blocking-b2g: 2.5+ → 2.6?
Flags: needinfo?(jocheng)
Priority: P2 → P3
Whiteboard: [ft:conndevices][partner-cherry-pick] → [ft:conndevices]
Let's fix this post 2.5
Summary: [TV][Browser][New Strings] Would be nice to have the same dialog box when the network is disconnected → [TV][Browser] Revise i10n string of fxa offline error message
Comment on attachment 8692761 [details] [review]
[gaia] danhuang1202:1223273_revise_fxa_offline_error_message > mozilla-b2g:master

Hi Yi-fan, this patch revise the offline error message when clicking fxa menu block without network connected. Thanks.
Attachment #8692761 - Flags: review?(yliao)
The follow up bug: bug 1228481, would use to discuss the issue of unify the dialog box style in TV.
Attachment #8692761 - Flags: review?(yliao) → review-
Attachment #8692761 - Flags: review- → review?(yliao)
Comment on attachment 8692761 [details] [review]
[gaia] danhuang1202:1223273_revise_fxa_offline_error_message > mozilla-b2g:master

The patch is updating by switch the l10n property load sequence in index.html. Thanks.
Comment on attachment 8692761 [details] [review]
[gaia] danhuang1202:1223273_revise_fxa_offline_error_message > mozilla-b2g:master

r+ with a nit. Thanks!
Attachment #8692761 - Flags: review?(yliao) → review+
Thanks for the review, and the nit also fixed.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/b04e417b7b45ec561a45437bb103b0134eaad44f.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8692761 [details] [review]
[gaia] danhuang1202:1223273_revise_fxa_offline_error_message > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1194108 
[User impact] if declined: Not align to the l10n string review result
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8bc52a7c3fafbbb7604cac79693db70311679586
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: Yes
Attachment #8692761 - Flags: approval-gaia-v2.5?
blocking-b2g: 2.6? → 2.5+
Comment on attachment 8692761 [details] [review]
[gaia] danhuang1202:1223273_revise_fxa_offline_error_message > mozilla-b2g:master

Approve for TV 2.5
Attachment #8692761 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
has problems during uplift :


Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 8bc52a7c3fafbbb7604cac79693db70311679586
error: could not apply 8bc52a7... Bug 1223273 - Revise l10n string of fxa offline error message. r=yifan
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
Flags: needinfo?(dhuang)
Blocks: 1222016
Depends on: 1227860
This bug's change is depended on bug 1227860, so please merge bug 1227860 first.
Flags: needinfo?(dhuang)
Verify this issue on the latest build.
1. The message "No network connection. You need to be online to use Firefox Sync." does not show up and then it directed to Firefox account page after selecting "Sign in to Sync" and pressing OK with disconnecting the network.
2. The message "Unable to Connect. Please connect to a network from Settings." shows up after entering your Firefox account email and pressing OK with disconnecting the network.
[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/d9faad5c0f14fcd42f920c9104f0638f46a48b2a
gecko:
https://hg.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: