1223295 - [preload-app-toolkit] Make packageEtag optional

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Oleg Zasypkin [:azasypkin][⏰UTC+1]]

It looks like that manifest etag is optional [1] while package etag is not [2]. But not every server supports etag and in it prevents us from hosting test Raptor apps at GitHub Pages (that doesn't support etag HTTP header) (see bug 1219176). So it seems reasonable to make etag optional for packageEtag as well.

As the future step it would be nice to leverage Last-Modified header as well, but it doesn't look easy to do as a lot of places rely on "etag" notion.


[1] https://github.com/mozilla-b2g/preload-app-toolkit/blob/37248465c8a1cef742b0c191571de26c1a0c3dff/preload.py#L242

[2] https://github.com/mozilla-b2g/preload-app-toolkit/blob/37248465c8a1cef742b0c191571de26c1a0c3dff/preload.py#L269

Comment 1

[Oleg Zasypkin [:azasypkin][⏰UTC+1]]

Attachment: https://github.com/mozilla-b2g/preload-app-toolkit/pull/76

Hey Fred,

Could you please help with review for this PR? We need this for bug 1219176.

Thanks!

Comment 2

[[e-mail]]

Comment on attachment 8685315 [details] [review]
https://github.com/mozilla-b2g/preload-app-toolkit/pull/76

looks good, thanks.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1223295-optional-package-etag > mozilla-b2g:master

Comment 4

[Oleg Zasypkin [:azasypkin][⏰UTC+1]]

Comment on attachment 8685383 [details] [review]
[gaia] azasypkin:bug-1223295-optional-package-etag > mozilla-b2g:master

Hey Fred,

Thanks for the quick review! Could you please help to merge it to the preaload-app-toolkit repo then and review this gaia-specific PR (same thing, but in gaia repo).

Thanks!

Comment 5

[[e-mail]]

Comment on attachment 8685383 [details] [review]
[gaia] azasypkin:bug-1223295-optional-package-etag > mozilla-b2g:master

you can carry on the r+ from mozilla-b2g/preload-app-toolkit

Comment 6

[[e-mail]]

merged preload-app-toolkit https://github.com/mozilla-b2g/preload-app-toolkit/commit/a17d0d7b3c7eb2f6d8b92f147005ddb123cc60ac

master https://github.com/mozilla-b2g/gaia/commit/41762dea5e29bc2cabe6263deb7fa825c91089e9

thanks

Comment 7

[Oleg Zasypkin [:azasypkin][⏰UTC+1]]

Thanks!