Closed Bug 1223295 Opened 7 years ago Closed 7 years ago

[preload-app-toolkit] Make packageEtag optional

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: azasypkin, Assigned: azasypkin)

References

Details

Attachments

(2 files)

It looks like that manifest etag is optional [1] while package etag is not [2]. But not every server supports etag and in it prevents us from hosting test Raptor apps at GitHub Pages (that doesn't support etag HTTP header) (see bug 1219176). So it seems reasonable to make etag optional for packageEtag as well.

As the future step it would be nice to leverage Last-Modified header as well, but it doesn't look easy to do as a lot of places rely on "etag" notion.


[1] https://github.com/mozilla-b2g/preload-app-toolkit/blob/37248465c8a1cef742b0c191571de26c1a0c3dff/preload.py#L242

[2] https://github.com/mozilla-b2g/preload-app-toolkit/blob/37248465c8a1cef742b0c191571de26c1a0c3dff/preload.py#L269
Hey Fred,

Could you please help with review for this PR? We need this for bug 1219176.

Thanks!
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Attachment #8685315 - Flags: review?(gasolin)
Comment on attachment 8685383 [details] [review]
[gaia] azasypkin:bug-1223295-optional-package-etag > mozilla-b2g:master

Hey Fred,

Thanks for the quick review! Could you please help to merge it to the preaload-app-toolkit repo then and review this gaia-specific PR (same thing, but in gaia repo).

Thanks!
Attachment #8685383 - Flags: review?(gasolin)
Comment on attachment 8685383 [details] [review]
[gaia] azasypkin:bug-1223295-optional-package-etag > mozilla-b2g:master

you can carry on the r+ from mozilla-b2g/preload-app-toolkit
Attachment #8685383 - Flags: review?(gasolin) → review+
Thanks!
You need to log in before you can comment on or make changes to this bug.