Closed
Bug 1223297
Opened 9 years ago
Closed 8 years ago
[Testcase] App should have the ability to playback different kinds of audio channel
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(1 file)
When the app have the multiple audio channels, we should make sure each channel can be playback successfully. See more details in [1]. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1186135#c10
Assignee | ||
Comment 1•9 years ago
|
||
Now I can't get the multiple audio channel channels in the mochitest. Even I added the permission in the manifest, the other channels (except normal) still can't be generated. Still finding the reason...
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1223297 - Multiple audio channel test.
Assignee | ||
Comment 3•9 years ago
|
||
Try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=1991ce20f38f
Assignee | ||
Comment 4•9 years ago
|
||
The test can pass on my local environment, but fail on the try-server. Still trying to find the solution...
Assignee | ||
Comment 5•9 years ago
|
||
I guess the problem might be caused by [1], we can't get the app from the AppService. Still debug for more details. [1] https://dxr.mozilla.org/mozilla-central/source/dom/html/nsBrowserElement.cpp#596
Assignee | ||
Comment 6•9 years ago
|
||
This test can't be ran on the emulator, because the test of emulator is running on the content process. Because of that, we can't get the app manifest in [1], then we can't get the app in [2]. Therefore, we would only have the "normal" type audio channel. [1] https://dxr.mozilla.org/mozilla-central/source/dom/html/nsGenericHTMLFrameElement.cpp#615 [2] https://dxr.mozilla.org/mozilla-central/source/dom/html/nsBrowserElement.cpp#599
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/1-2/
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/2-3/
Assignee | ||
Comment 9•9 years ago
|
||
Try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=314eb52b41c9
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/3-4/
Attachment #8685923 -
Flags: review?(amarchesini)
Assignee | ||
Comment 11•9 years ago
|
||
Hi, Baku, Could you help me review this patch? It's about to test whether we can receive the "activestatechanged" event from different type audio channels within the same app, the previous bug is [1]. As emulator runs the mochitest tests on the content process, it caused that we can't get the manifest from the mozBrowerFrame [2]. Therefore, I need to use the "chrome" test. Very appreciate!! --- [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1186135#c10 [2] https://dxr.mozilla.org/mozilla-central/source/dom/html/nsBrowserElement.cpp?from=nsBrowserElement.cpp#561
Assignee | ||
Comment 12•9 years ago
|
||
New try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d6377db331a
Comment 13•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. https://reviewboard.mozilla.org/r/24923/#review22941 ::: dom/browser-element/mochitest/browserElement_MultipleAudioChannels.js:40 (Diff revision 4) > +function showTestInfo(aEnable) { aOOPCEnabled ::: dom/browser-element/mochitest/browserElement_MultipleAudioChannels.js:62 (Diff revision 4) > +function runTest(aEnable) { aOOPCEnabled ? ::: dom/browser-element/mochitest/chrome.ini:5 (Diff revision 4) > + ../../../browser/base/content/test/general/audio.ogg copy this file in this directory. Good to have more tests!
Attachment #8685923 -
Flags: review?(amarchesini)
Comment 14•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. https://reviewboard.mozilla.org/r/24923/#review22943
Attachment #8685923 -
Flags: review+
Assignee | ||
Comment 15•9 years ago
|
||
It seems that my patch would cause the "test_browserElement_NotifyChannel.html" time-out. Need to find the reason.
Assignee | ||
Updated•9 years ago
|
Attachment #8685923 -
Attachment description: MozReview Request: Bug 1223297 - Multiple audio channel test. → MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku.
Attachment #8685923 -
Flags: review+
Assignee | ||
Comment 16•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/4-5/
Assignee | ||
Comment 17•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=03a2ef1a7861
Assignee | ||
Comment 18•9 years ago
|
||
Hi, Baku, Do you have any idea about the test case timeout? It seems that my patch cause another chrome case timeout, but I have no idea why it happened. These two tests can work successfully in my local emulator. Very appreciate!
Flags: needinfo?(amarchesini)
Comment 19•9 years ago
|
||
You timeout in the following test, not in yours. This means the the iframe where you do tests is not fully closed? Here some questions: 1. Do you remove it from the document? 2. If not, do you stop any media element before terminating your test?
Flags: needinfo?(amarchesini)
Assignee | ||
Updated•9 years ago
|
Summary: [B2G] Add the test to make sure that multiple channels can be playback under the same window → [Testcase] App should have the ability to playback different kinds of audio channel
Assignee | ||
Comment 20•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=83905640e93c
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 21•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/5-6/
Attachment #8685923 -
Flags: review?(amarchesini)
Assignee | ||
Updated•9 years ago
|
Attachment #8685923 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 22•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f872e2e952af
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 23•9 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/fdbc50946db3
Keywords: checkin-needed
Comment 24•9 years ago
|
||
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=3496268&repo=b2g-inbound
Flags: needinfo?(alwu)
Comment 25•9 years ago
|
||
Backout: https://hg.mozilla.org/integration/b2g-inbound/rev/a8e464c7dc5c
Assignee | ||
Comment 26•9 years ago
|
||
New try-server result. https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6e3edfc28c4
Comment 27•9 years ago
|
||
seems also https://treeherder.mozilla.org/logviewer.html#?job_id=3499136&repo=b2g-inbound was realted to this
Assignee | ||
Comment 28•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=efc6e4eb92e9
Flags: needinfo?(alwu)
Assignee | ||
Comment 29•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/6-7/
Attachment #8685923 -
Flags: review+ → review?(amarchesini)
Assignee | ||
Updated•9 years ago
|
Attachment #8685923 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 30•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=de170d3a6daf
Comment 31•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. https://reviewboard.mozilla.org/r/24923/#review24791
Attachment #8685923 -
Flags: review+
Assignee | ||
Comment 32•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c2e181917ff7
Assignee | ||
Comment 33•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=665f6830d7bf
Assignee | ||
Comment 34•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/7-8/
Attachment #8685923 -
Flags: review+
Assignee | ||
Comment 35•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=521cf79f1370
Assignee | ||
Comment 36•9 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/8-9/
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 37•8 years ago
|
||
Please do a try push with some desktop platforms too. The patch looks very fishy, because it updates chrome.ini/mochitest.ini files to move around audio.ogg, but the patch itself doesn't move that file. I strongly suspect the test_browserElement_MultipleAudioChannels.html test will fail on desktop.
Flags: needinfo?(alwu)
Keywords: checkin-needed
Assignee | ||
Comment 38•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbf71215f61e
Flags: needinfo?(alwu)
Assignee | ||
Comment 39•8 years ago
|
||
Hi, Kart, The chrome.ini/mochitest.ini need "audio.ogg", so this patch also included the changeset of creating a new file. So I don't very understand what you means.
Flags: needinfo?(bugmail.mozilla)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 40•8 years ago
|
||
Ah, my bad. When I imported the patch from reviewboard it didn't have the audio.ogg file but it looks like it's a problem with importing from reviewboard. I've filed bug 1235254 for that. I'll land the patch you pushed to try.
Flags: needinfo?(bugmail.mozilla)
Comment 41•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bb04c310d05
Keywords: checkin-needed
Comment 42•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/210aaacaf2b1 for Android M(4) test failure, the one in bug 1228564 didn't help: Backout job: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=210aaacaf2b1 E.g. https://treeherder.mozilla.org/logviewer.html#?job_id=19026021&repo=mozilla-inbound 08:03:06 INFO - 51 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | iframe.mute exists 08:03:06 INFO - 52 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | iframe.unmute exists 08:03:06 INFO - 53 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | iframe.getMuted exists 08:03:06 INFO - 54 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | iframe.getVolume exists 08:03:06 INFO - 55 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | iframe.setVolume exists 08:03:06 INFO - 56 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | allowedAudioChannels exist 08:03:06 INFO - 57 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | 1 audio channel by default 08:03:06 INFO - 58 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | Correct class 08:03:06 INFO - 59 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | ac.getVolume exists 08:03:06 INFO - 60 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | ac.setVolume exists 08:03:06 INFO - 61 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | ac.getMuted exists 08:03:06 INFO - 62 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | ac.setMuted exists 08:03:06 INFO - 63 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | ac.isActive exists 08:03:06 INFO - 64 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | undefined assertion name 08:03:06 INFO - 65 INFO Test : audio-muted-by-default 08:03:06 INFO - 66 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | allowedAudioChannels exist 08:03:06 INFO - 67 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | 1 audio channel by default 08:03:06 INFO - 68 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | Correct class 08:03:06 INFO - 69 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | ac.getMuted exists 08:03:06 INFO - 70 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | ac.setMuted exists 08:03:06 INFO - 71 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | activestatechanged event received. 08:03:06 INFO - 72 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | Muted channel by default 08:03:06 INFO - 73 INFO TEST-PASS | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | Unmuted the channel. 08:03:06 INFO - 74 INFO TEST-UNEXPECTED-FAIL | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | Test timed out. 08:03:06 INFO - reportError@SimpleTest/TestRunner.js:114:7 08:03:06 INFO - TestRunner._checkForHangs@SimpleTest/TestRunner.js:134:7 08:03:18 INFO - 75 INFO TEST-OK | dom/browser-element/mochitest/test_browserElement_inproc_AudioChannel.html | took 312972ms
Flags: needinfo?(alwu)
Assignee | ||
Comment 43•8 years ago
|
||
Hi, Sebastian, From the comment38, this patch should pass the tests. Does this fail come along with landing the bug1228564 at the same time? Or get fail when only landing this bug? Because I am guessing that the failed might be resulted by landing both this issue and bug1228564, only landing this bug should be no problem. Thanks!
Flags: needinfo?(alwu) → needinfo?(aryx.bugmail)
Assignee | ||
Comment 44•8 years ago
|
||
After repush my patch to the try-server, now I can see that fail. Need to investigate it.
Flags: needinfo?(aryx.bugmail)
Assignee | ||
Comment 45•8 years ago
|
||
I guess the time-out might be caused by test_browserElement_inproc_AudioChannel.html doesn't be implemented well in bug1223261. I am trying to re-write that test to see whether we can avoid the time-out.
Assignee | ||
Comment 46•8 years ago
|
||
Only this bug : https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6f146793ee5 Bug 1235535 + this bug : https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb960439aaa2
Assignee | ||
Comment 47•8 years ago
|
||
Comment on attachment 8685923 [details] MozReview Request: Bug 1223297 - Multiple audio channel test. r=baku. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24923/diff/9-10/
Comment 49•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1f2b22e3108
Keywords: checkin-needed
Comment 50•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b1f2b22e3108
You need to log in
before you can comment on or make changes to this bug.
Description
•