Closed Bug 1223321 Opened 4 years ago Closed 4 years ago

Intermittent apps/homescreen/test/marionette/app_order_test.js | Homescreen - App order App order is retained after restart

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.6+)

RESOLVED FIXED
2.6 S5 - 1/15
feature-b2g 2.6+

People

(Reporter: gwagner, Assigned: cwiiis)

References

Details

(Keywords: intermittent-failure, Whiteboard: [systemsfe] [MJS] [intermittents])

Attachments

(2 files)

No description provided.
Blocks: 1222215
Whiteboard: [systemsfe]
feature-b2g: --- → 2.6+
Whiteboard: [systemsfe] → [systemsfe] [MJS]
Assignee: nobody → chrislord.net
Status: NEW → ASSIGNED
Comment on attachment 8695941 [details] [review]
[gaia] Cwiiis:bug1223321-intermittent-app-order-test > mozilla-b2g:master

Treeherder with the test passing 50 times consecutively: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=00eef9890536f1c55726cab4d4259469c20926b9

(ignore the second commit of course, will remove before merging)
Attachment #8695941 - Flags: review?(gmarty)
Pushed a slight simplification and removed the testing script changes so it's ready to merge.
Comment on attachment 8695941 [details] [review]
[gaia] Cwiiis:bug1223321-intermittent-app-order-test > mozilla-b2g:master

That's a lot of code to ensure stability. I'd love to see that moved into a lib, but if it's not going to be used again, then I'm happy with this.
Attachment #8695941 - Flags: review?(gmarty) → review+
(In reply to Guillaume Marty [:gmarty] from comment #4)
> Comment on attachment 8695941 [details] [review]
> [gaia] Cwiiis:bug1223321-intermittent-app-order-test > mozilla-b2g:master
> 
> That's a lot of code to ensure stability. I'd love to see that moved into a
> lib, but if it's not going to be used again, then I'm happy with this.

mmm... Let's move it to the lib as soon as it's used in one more file (so I guess when you need to do page_order_test :))
Merged: https://github.com/mozilla-b2g/gaia/commit/3be44c7a1b09a9325ef50564263eea98b3239be0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I'm still seeing this issue, especially after disabling the retry logic in bug 1222215 [1][2]. Let's disable this test for now to unblock bug 1222215.

1.) https://treeherder.mozilla.org/logviewer.html#?job_id=3214692&repo=gaia
2.) https://treeherder.mozilla.org/logviewer.html#?job_id=3241122&repo=gaia
No longer blocks: 1222215
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [systemsfe] [MJS] → [systemsfe] [MJS] [intermittents]
Target Milestone: --- → 2.6 S5 - 1/15
(In reply to Michael Henretty [:mhenretty] from comment #7)
> I'm still seeing this issue, especially after disabling the retry logic in
> bug 1222215 [1][2]. Let's disable this test for now to unblock bug 1222215.
> 
> 1.) https://treeherder.mozilla.org/logviewer.html#?job_id=3214692&repo=gaia
> 2.) https://treeherder.mozilla.org/logviewer.html#?job_id=3241122&repo=gaia

The second failure here I can't do anything about without a proper log (we really need to get bug 1175116 fixed...), but the first is weird. The calendar app isn't even fully visible on the screen on startup, so that's a very odd bug... It could be that the apps list isn't fully loaded when dragging the apps, possibly... Not something I can reproduce locally though, so this is going to be a bit of a stab in the dark to fix. If it's that, it should be reasonably simple to craft a patch to fix it.
Blocks: 1233525
Comment on attachment 8704619 [details] [review]
[gaia] Cwiiis:bug1223321-homescreen-intermittent-app-order-test > mozilla-b2g:master

Again, I believe this is 50 consecutive green runs, this time without disabling other tests: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=39adc50b4f8b89074fb940a91cdbd3440658ebdc&selectedJob=3321165

I don't think I can do much better than this without better information, but this may fix it? I guess let's commit and try...

(this may also fix some other homescreen intermittents)
Attachment #8704619 - Flags: review?(gmarty)
Comment on attachment 8704619 [details] [review]
[gaia] Cwiiis:bug1223321-homescreen-intermittent-app-order-test > mozilla-b2g:master

LGTM!
Attachment #8704619 - Flags: review?(gmarty) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/f825f86f8553448eec38b6d4d5b9b8452364e18a

Fingers crossed!
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.