clicking on marketplace icon from home page unnecessarily refresh page

RESOLVED WONTFIX

Status

P5
trivial
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: ramd, Assigned: trishul.goel)

Tracking

Avenir
Points:
---

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
STR -
1. Open marketplace app on phone (make sure you are on home page)
2. Click on marketplace icon shown on top left corner.

It refreshes the page, which is not actually necessary.
Severity: normal → trivial
Priority: -- → P5
Whiteboard: [ktlo]
(Assignee)

Comment 1

3 years ago
Created attachment 8701109 [details] [review]
Pull Request

Initial design used Logo icon as button to move back to homepage, in new design, the Logo is only on homepage so we don't need anchor tag on logo.
Assignee: nobody → trishul.goel
Status: NEW → ASSIGNED
Flags: needinfo?(dspasovski)
Whiteboard: [ktlo] → [good first bug]
(Assignee)

Comment 2

3 years ago
Modifying href fails travis checks, any idea?
Flags: needinfo?(dspasovski) → needinfo?(ddurst)
Flags: needinfo?(ddurst) → needinfo?(dspasovski)
I kind of want to say this bug is invalid itself and we shouldn't be working on it. The tests rely on clicking the logo in a few places to get back to the homepage. If you wish to change the tests (you'd have to change both mobile and desktop) you're welcome to though it won't be simple since you'd need a guaranteed way for casper to get back to the homepage.

Long story short...not worth the effort. If someone clicks the logo a refresh isn't the worst thing.
Flags: needinfo?(dspasovski)
(Assignee)

Comment 4

3 years ago
As per comment 3, closing this bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.