1223368 - Make searchbox style consistent across tools

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P5)

Comment 1

[Belén [:ladybenko]]

Hi Victoria! Is the searchbox style in the Photon guidelines the one we need to use everywhere? https://firefox-dev.tools/photon/components/input-fields.html Are there some panels that should have a different style for their searchboxes? Thanks!

Comment 2

[Victoria Wang [:victoria]]

Hi Belén! For in-content pages like about:debugging, that page has the correct styling. Search boxes inside DevTools panels should follow the more minimal style currently in Netmonitor/Console. More info: https://mozilla.invisionapp.com/share/2XEEY0RYA#/screens/263398480

Comment 3

[Mellina Y.]

Hi everyone,

I was wondering if I could try to solve this if this is available.

For this issue, tools mentioned are the tabs in the Devtools?
I can check all occurrences of the searchbox and log here so you can check if they are all that need to be changed.

Thanks!

Comment 4

[Victoria Wang [:victoria]]

Hi Mellina, sorry again for the late reply!

Currently, the Inspector part of this is being worked on in this bug. I think Gabe mentioned he could could apply this to other areas (Style Editor, Network headers?) while he's at it. If that's the case, he might want to take over this bug.

Comment 5

[Tim Nguyen :ntim]

Attachment: Bug 1223368 - Refactor searchbox style to be consistent across tools.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8a2cbf18f3c
Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe

Comment 7

[Arthur Iakab [arthur_iakab]]

Backed out changeset c8a2cbf18f3c (bug 1223368) for devtools failures on browser_inspector_search-01.js CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/a9241feee65fa53207166a45e2682fd238f6dfa0

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=245971949&revision=c8a2cbf18f3c8434aa69b21db050fe7af1f19251

Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=245971757&repo=autoland

Tim can you please take a look?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/784c0c4b688b
Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4440662cd017
Followup: fix browser_inspector_search-01/06.js failures on a CLOSED TREE. r=me

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/784c0c4b688b
https://hg.mozilla.org/mozilla-central/rev/4440662cd017

Comment 11

[Gabriel Luong [:gl] (ΦωΦ)]

Clearing needinfo since this is fixed.