Closed Bug 1223374 Opened 9 years ago Closed 9 years ago

Convert bookmark_invalid_favicon_test.js tests to Pinning

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.6 S1 - 11/20

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] mikehenrty:bug-1223374-bookmark-favicon-to-pinning > mozilla-b2g:master
46 bytes, text/x-github-pull-request
cwiiis
: review+
Details | Review 
      No description provided.
Comment on attachment 8685457 [details] [review]
[gaia] mikehenrty:bug-1223374-bookmark-favicon-to-pinning > mozilla-b2g:master

Ok, let's migrate these tests one by one. Chris, wanna be the reviewer here?
Attachment #8685457 - Flags: review?(chrislord.net)
Here's a link to see how intermittent the new test will be (once we disable the retry logic).

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7fbe63c340268d6971867df7eb76c8cac63b1478
Comment on attachment 8685457 [details] [review]
[gaia] mikehenrty:bug-1223374-bookmark-favicon-to-pinning > mozilla-b2g:master

Looks good, thanks :)
Attachment #8685457 - Flags: review?(chrislord.net) → review+
Not seeing any failures in this test in the link [1]. I think this one is good to go.

1.) https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7fbe63c340268d6971867df7eb76c8cac63b1478
master: https://github.com/mozilla-b2g/gaia/commit/c8c55fa52206e0b19e43beba34aa34ffbdf06120
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S1 - 11/20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: