Build: Beta 1202 iPad Air 2 (9.1) Steps: 1. Tap on share button while the device is in portrait mode 2. Switch to landscape Result: The share menu is misplaced after switching orientation
Comment on attachment 8686546 [details] [review] Pull request I think this looks good but I think it will be good if :sleroux can take a peek too.
Comment on attachment 8686546 [details] [review] Pull request Good approach - just left some comments about the deprecated API and some minor clean up we can do.
Attachment #8686546 - Flags: feedback+
Assignee: nobody → philippe.bernery
Status: NEW → ASSIGNED
I updated my PR following your recommendations.
One last night and I think we're good to go :)
PR updated :)
Comment on attachment 8686546 [details] [review] Pull request Awesome! Thanks for fixing it up. I'll go ahead and land it.
Attachment #8686546 - Flags: review?(sleroux) → review+
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Whiteboard: [good first bug][lang=swift] → [needsuplift]
Verifying as fixed on TF build 1303
You need to log in before you can comment on or make changes to this bug.