Closed
Bug 1223386
Opened 9 years ago
Closed 9 years ago
Share menu is misplaced after changing orientation on iPads
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
1.3
| Tracking | Status | |
|---|---|---|
| fxios | 1.3+ | --- |
People
(Reporter: csuciu, Assigned: philippe.bernery, Mentored)
Details
(Keywords: polish)
Attachments
(2 files)
Screen Shot 2015-11-10 at 16.38.09.png
Build: Beta 1202
iPad Air 2 (9.1)
Steps:
1. Tap on share button while the device is in portrait mode
2. Switch to landscape
Result: The share menu is misplaced after switching orientation
|
Reporter | |
Comment 1•9 years ago
|
||
|
||
Updated•9 years ago
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8686546 -
Flags: review?(sarentz)
|
||
Updated•9 years ago
|
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8686546 [details] [review]
Pull request
I think this looks good but I think it will be good if :sleroux can take a peek too.
Attachment #8686546 -
Flags: review?(sleroux)
Attachment #8686546 -
Flags: review?(sarentz)
Attachment #8686546 -
Flags: review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8686546 [details] [review]
Pull request
Good approach - just left some comments about the deprecated API and some minor clean up we can do.
Attachment #8686546 -
Flags: feedback+
|
|
||
Updated•9 years ago
|
Assignee: nobody → philippe.bernery
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•9 years ago
|
||
I updated my PR following your recommendations.
|
|
||
Comment 6•9 years ago
|
||
One last night and I think we're good to go :)
|
||
Updated•9 years ago
|
Rank: 3
|
|
Assignee | |
Comment 7•9 years ago
|
||
PR updated :)
|
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8686546 [details] [review]
Pull request
Awesome! Thanks for fixing it up. I'll go ahead and land it.
Attachment #8686546 -
Flags: review?(sleroux) → review+
|
|
||
Comment 9•9 years ago
|
||
Landed
f09aa73786006634c7179ee5ef48331b37da87a1
|
|
||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
|
|
||
Updated•9 years ago
|
Whiteboard: [good first bug][lang=swift] → [needsuplift]
|
|
||
Updated•9 years ago
|
Whiteboard: [needsuplift]
|
|
Reporter | |
Comment 10•9 years ago
|
||
Verifying as fixed on TF build 1303
Flags: needinfo?(catalin.suciu)
Keywords: verifyme
|
|
Reporter | |
Updated•9 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•