Share menu is misplaced after changing orientation on iPads

VERIFIED FIXED in 1.3

Status

()

defect
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: csuciu, Assigned: philippe.bernery, Mentored)

Tracking

({polish})

unspecified
Other
iOS

Firefox Tracking Flags

(fxios1.3+)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Build: Beta 1202
iPad Air 2 (9.1)

Steps:
1. Tap on share button while the device is in portrait mode
2. Switch to landscape

Result: The share menu is misplaced after switching orientation
Mentor: sleroux
Keywords: polish
Whiteboard: [good first bug][lang=swift]
(Assignee)

Comment 2

4 years ago
Posted file Pull request
Attachment #8686546 - Flags: review?(sarentz)
Comment on attachment 8686546 [details] [review]
Pull request

I think this looks good but I think it will be good if :sleroux can take a peek too.
Attachment #8686546 - Flags: review?(sleroux)
Attachment #8686546 - Flags: review?(sarentz)
Attachment #8686546 - Flags: review+
Comment on attachment 8686546 [details] [review]
Pull request

Good approach - just left some comments about the deprecated API and some minor clean up we can do.
Attachment #8686546 - Flags: feedback+
Assignee: nobody → philippe.bernery
Status: NEW → ASSIGNED
(Assignee)

Comment 5

3 years ago
I updated my PR following your recommendations.
One last night and I think we're good to go :)
Rank: 3
(Assignee)

Comment 7

3 years ago
PR updated :)
Comment on attachment 8686546 [details] [review]
Pull request

Awesome! Thanks for fixing it up. I'll go ahead and land it.
Attachment #8686546 - Flags: review?(sleroux) → review+
Landed

f09aa73786006634c7179ee5ef48331b37da87a1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
Whiteboard: [good first bug][lang=swift] → [needsuplift]
Flags: needinfo?(catalin.suciu)
Keywords: verifyme
Whiteboard: [needsuplift]
(Reporter)

Comment 10

3 years ago
Verifying as fixed on TF build 1303
Flags: needinfo?(catalin.suciu)
Keywords: verifyme
(Reporter)

Updated

3 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.