Replace SwiftKeychainWrapper source with Carthage import

RESOLVED FIXED

Status

()

Firefox for iOS
Build & Test
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: sleroux, Assigned: fluffyemily)

Tracking

unspecified
All
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios2.0+)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
There's an open issue to support Carthage and it looks like it's working but might need to be updated to Swift 2.1 to avoid warnings:

https://github.com/jrendel/SwiftKeychainWrapper/issues/14

Since 2.0 -> 2.1 isn't too bad, we can even submit a patch to get it in a non-warning state. Looks like it's working though.
(Reporter)

Updated

3 years ago
Blocks: 1223403

Comment 1

3 years ago
There is an open pull request that removes the warnings (see [1]). However, these are only warnings and on top they only affect the unit tests so there should be nothing blocking the build.

[1] https://github.com/jrendel/SwiftKeychainWrapper/pull/25

Comment 2

3 years ago
The PR was merged so there should be no warnings anymore.
(Reporter)

Updated

3 years ago
tracking-fxios: ? → ---
Blocks: 1228912
tracking-fxios: --- → 2.0+
Hardware: Other → All
(Assignee)

Comment 3

2 years ago
Created attachment 8704142 [details] [review]
Pull request

Part 1 of using carthage correctly - move GDCWebserver in ThirdParty to reference version fetched by carthage
Attachment #8704142 - Flags: review?(sleroux)
(Assignee)

Updated

2 years ago
Assignee: nobody → etoop
Status: NEW → ASSIGNED
(Assignee)

Comment 4

2 years ago
:sleroux - pinned GCDWebServer and SwiftKeychainWrapper to a particular version
(Reporter)

Updated

2 years ago
Attachment #8704142 - Flags: review?(sleroux) → review+
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.