1223420 - Avoid creating intermediate array in DataAdapter update functions for history and bookmarks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect)

Description

[Michiel de Jong [:michielbdejong]]

The current DataAdapters for history and bookmarks have an update function which calls an _update function which loops over the Kinto collection to fill an array. This array is then passed to HistoryHelper.updatePlaces or BookmarksHelper.updateBookmarks, and is looped over a second time in order to make the necessary changes in the DataStore for each record.

Creating this array and then looping over essentially the same records a second time is probably not very memory-efficient (and probably also not so time-efficient).

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1223420-avoid-intermediate-array > mozilla-b2g:master

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8686088 [details] [review]
[gaia] michielbdejong:1223420-avoid-intermediate-array > mozilla-b2g:master

Hi Michiel, Could you rebase the patch to master branch? That would be easier to review and test your patch. Thank you! :)

Comment 3

[Michiel de Jong [:michielbdejong]]

OK! Rebased.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8686088 [details] [review]
[gaia] michielbdejong:1223420-avoid-intermediate-array > mozilla-b2g:master

Hi Michiel, Thanks for doing this refactor and LGTM :)
I leave one minor question about the test context.

Comment 5

[Michiel de Jong [:michielbdejong]]

Thanks!!
Rebased and edited r=.

Comment 6

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/e854b36d51c28abac92c76bf4a322bd49c480fa5
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8f00d8ed868452163990061200af0c6f3681c8dd