1223447 - Flame 2.5 needs FOTA builds

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1) due to the size limitation issue, we had decided to FOTA for 2.5
2) There's a gecko/gaia specific FOTA that we need to do.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1037056

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note, looks like the pvtbuild/buildbot makes FOTA 2.5 builds.  TC builds look like OTA.

So we either need to turn pvtbuilds /build bot back on for 2.5 or have TC builds create FOTA instead.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

see bug 1223259 : https://treeherder.allizom.org/#/jobs?repo=mozilla-b2g44_v2_5&revision=361f2673aadc

Comment 3

[Wander Lairson Costa]

Attachment: Enable fota builds for flame and nexus devices. r=jlund

Comment 4

[Wander Lairson Costa]

Comment on attachment 8685696 [details] [diff] [review]
Enable fota builds for flame and nexus devices. r=jlund

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ec5b938041a

Builds:
https://tools.taskcluster.net/task-inspector/#Fa4P-yinQiiPvQCz2DVzig/
https://tools.taskcluster.net/task-inspector/#KYszyvBeR8K4SYrQZzAzYw/

This needs to uplift to b2g44_v2_5, but the channel name needs updating to nightly-b2g44.

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8685696 [details] [diff] [review]
Enable fota builds for flame and nexus devices. r=jlund

Review of attachment 8685696 [details] [diff] [review]:
-----------------------------------------------------------------

lgmt

::: testing/mozharness/configs/b2g/taskcluster-phone-fota.py
@@ +37,5 @@
> +    "env": {
> +        "GAIA_OPTIMIZE": "1",
> +        "WGET_OPTS": "-c -q"
> +    },
> +    "update_types": [ "ota", "fota" ],

is this the only difference between taskcluster-phone-ota.py and this file? If so, we should look into passing update_types via cmd line and sharing the config. Shame to have all this duplication.

::: testing/taskcluster/tasks/builds/b2g_nexus_5l_ota_debug.yml
@@ +23,5 @@
>        B2G_DEBUG: 0
>        TARGET: 'nexus-5-l'
>        DEBUG: 0
>        DOGFOOD: 1
> +      MOZHARNESS_CONFIG: b2g/taskcluster-phone-fota.py

where was MOZHARNESS_CONFIG getting set before for these? I tried bubbling up b2g_phone_base.yml to see what config these tasks were passing to build-phone-ota.sh but it doesn't look like we define MOZHARNESS_CONFIG there..

Comment 6

[Wander Lairson Costa]

(In reply to Jordan Lund (:jlund) from comment #5)
> Comment on attachment 8685696 [details] [diff] [review]
> Enable fota builds for flame and nexus devices. r=jlund
> 
> Review of attachment 8685696 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> lgmt
> 
> ::: testing/mozharness/configs/b2g/taskcluster-phone-fota.py
> @@ +37,5 @@
> > +    "env": {
> > +        "GAIA_OPTIMIZE": "1",
> > +        "WGET_OPTS": "-c -q"
> > +    },
> > +    "update_types": [ "ota", "fota" ],
> 
> is this the only difference between taskcluster-phone-ota.py and this file?
> If so, we should look into passing update_types via cmd line and sharing the
> config. Shame to have all this duplication.
> 
> ::: testing/taskcluster/tasks/builds/b2g_nexus_5l_ota_debug.yml
> @@ +23,5 @@
> >        B2G_DEBUG: 0
> >        TARGET: 'nexus-5-l'
> >        DEBUG: 0
> >        DOGFOOD: 1
> > +      MOZHARNESS_CONFIG: b2g/taskcluster-phone-fota.py
> 
> where was MOZHARNESS_CONFIG getting set before for these? I tried bubbling
> up b2g_phone_base.yml to see what config these tasks were passing to
> build-phone-ota.sh but it doesn't look like we define MOZHARNESS_CONFIG
> there..

It defaults to taskcluster-phone-ota.py

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/baa579f72288

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/baa579f72288