1223452 - avoid Cu.importGlobalProperties in devtools

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Tom Tromey :tromey]

Bug 1216234 had some issues that turned out to be that, at the end of
a require chain, one file did Cu.importGlobalProperties -- and if this
wasn't run, the code would fail.

It's better to avoid importGlobalProperties and instead make special
modules in Loader.jsm that can be required.  This will avoid confusing
results like that.

Comment 1

[Tom Tromey :tromey]

Attachment: avoid Cu.importGlobalProperties

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8685555 [details] [diff] [review]
avoid Cu.importGlobalProperties

Review of attachment 8685555 [details] [diff] [review]:
-----------------------------------------------------------------

Note that Sandboxes have a significant memory cost. I think it's ok, but we should share a common sandbox if we start doing this for new symbols.

Comment 3

[Tom Tromey :tromey]

Attachment: avoid Cu.importGlobalProperties

Rebased; added r= to commit.

Comment 4

[Tom Tromey :tromey]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=57069d70a8b6

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/1497b7791bda

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1497b7791bda