1223490 - Use stable hashing for InnerViewsTable

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

This is the table that allows keys to be in the nursery. IIRC, the trivial fix I tried a few weeks ago fell over because of a disagreement about when pointers are supposed to get updated. Am taking another look now.

Comment 1

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=36f381c5d9e1

Comment 2

[Terrence Cole [:terrence]]

Attachment: stable_InnerViewTable-v0.diff

Yeah, we just needed to be a bit careful about how we check for and relocate the pointer when sweeping after a moving GC. Will be interesting to see the results for the cgc run.

We should be able to generalize this and have all of our weak caches allow nursery pointers without automatically tenuring. That can happen later though.

Comment 3

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28f07321a826

Comment 4

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f06692c64ba

Comment 5

[Terrence Cole [:terrence]]

Attachment: stable_InnerViewTable-v1.diff

I missed one subtlety about how nurseryKeys interacts with the map.

Comment 6

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b07dc29becd1

Comment 7

[Jon Coppeard (:jonco)]

Comment on attachment 8686115 [details] [diff] [review]
stable_InnerViewTable-v1.diff

Review of attachment 8686115 [details] [diff] [review]:
-----------------------------------------------------------------

Great, this this nice.

Comment 8

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72fca915afab7f7606c3aabaa6f62ec604ab0c42
Bug 1223490 - Use stable hashing for InnerViewTable; r=jonco

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/72fca915afab