Closed
Bug 1223503
Opened 9 years ago
Closed 9 years ago
Job rendering code in UI could be simplified a bit
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
While trying to diagnose the issues behind a treeherder memory leak (see bug 1223445), I realized that some of the code to populate the jobs table could be simplified a bit. There are other fixes we should consider (not using jQuery selectors to construct html content for one, which I suspect is the cause of the memory leak), but I figured at least clarifying the existing code would be a start.
|
Assignee | |
Comment 1•9 years ago
|
||
Pretty straightforward refactoring/simplification. Works good locally.
Attachment #8685552 -
Flags: review?(cdawson)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8685552 [details] [review] PR I did some testing of this myself. It seems to work well.
Attachment #8685552 -
Flags: review?(cdawson) → review+
|
||
Comment 3•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/07012fb925dbf731fd4ffe71254dcc2c22c217db Bug 1223503 - Simplify population of job groups in frontend
|
|
Assignee | |
Comment 4•9 years ago
|
||
Checked in a slightly updated/rebased patch (camd changed some related code in bug 1197258).
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Summary: Job code could be simplified a bit → Job rendering code in UI could be simplified a bit
You need to log in
before you can comment on or make changes to this bug.
Description
•