Closed Bug 1223529 Opened 9 years ago Closed 9 years ago

remove ipc/chromium/Makefile.in

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: ted, Assigned: ted)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

MozReview Request: bug 1223529 - remove ipc/chromium/Makefile.in. r?gps
40 bytes, text/x-review-board-request
gps
: review+
Details 
Turns out most of it is vestigal.
bug 1223529 - remove ipc/chromium/Makefile.in. r?gps
Attachment #8685596 - Flags: review?(gps)
Attachment #8685596 - Flags: review?(gps) → review+
Comment on attachment 8685596 [details]
MozReview Request: bug 1223529 - remove ipc/chromium/Makefile.in. r?gps

https://reviewboard.mozilla.org/r/24853/#review22379

That's a low signal to noise ratio in the Makefile.in!
I don't think we've been very good about cleaning up historical cruft as we've made improvements in the build system.

Also, the rule to generate event.h was a pretty hacky workaround to avoid changing that include path (presumably trying to keep the fiction that ipc/chromium was upstream code).
https://hg.mozilla.org/mozilla-central/rev/887c67fc1fc8
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: