1223536 - [B2G] Add alternative punctuation marks to Ukrainian keyboard layout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Artem Polivanchuk]

Attachment: 2015-10-22-17-11-57.png

Please add alternative punctuation marks, which appears by long tap on "."
It should be the same as for en layout.

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Adding Tim so he can take a look and possibly assign someone to this. Thanks :)

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] stenox:patch-1 > mozilla-b2g:master

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8692991 [details] [review]
[gaia] stenox:patch-1 > mozilla-b2g:master

Thanks for helping out! However this caused a JS Error according to the test result. Please fix it and ask for review again!

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] stenox:master > mozilla-b2g:master

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] stenox:master > mozilla-b2g:master

Comment 6

[Artem Polivanchuk]

Comment on attachment 8714216 [details] [review]
[gaia] stenox:master > mozilla-b2g:master

Thanks for reviewing!
Now I fixed missing comma and sent PR.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8714216 [details] [review]
[gaia] stenox:master > mozilla-b2g:master

Looks good except you would need to squash the commits.

Please ask for check-in after that.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] stenox:patch-1 > mozilla-b2g:master

Comment 9

[Artem Polivanchuk]

Comment on attachment 8714432 [details] [review]
[gaia] stenox:patch-1 > mozilla-b2g:master

I don't familiar on how to squash commits yet, so I just created new PR with one commit.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/97804067a525c9cd35660f523c4bee9122b39ced

Thanks for the contribution!