1223565 - [traceback] `request.QUERY_PARAMS` has been deprecated in favor of `request.query_params` since version 3.0, and has been fully removed as of version 3.2.

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Michael Cooper [:mythmon]]

Looks like we missed this when we upgraded DRF. This bug covers fixing the problem and adding tests that cover this case.


NotImplementedError: `request.QUERY_PARAMS` has been deprecated in favor of `request.query_params` since version 3.0, and has been fully removed as of version 3.2.

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 497, in wrapper
    return wrapped(*args, **kwargs)
  File "django/views/decorators/csrf.py", line 57, in wrapped_view
    return view_func(*args, **kwargs)
  File "django/views/generic/base.py", line 69, in view
    return self.dispatch(request, *args, **kwargs)
  File "newrelic/hooks/component_djangorestframework.py", line 27, in _nr_wrapper_APIView_dispatch_
    return wrapped(*args, **kwargs)
  File "rest_framework/views.py", line 466, in dispatch
    response = self.handle_exception(exc)
  File "rest_framework/views.py", line 463, in dispatch
    response = handler(request, *args, **kwargs)
  File "rest_framework/generics.py", line 201, in get
    return self.list(request, *args, **kwargs)
  File "rest_framework/mixins.py", line 40, in list
    queryset = self.filter_queryset(self.get_queryset())
  File "kitsune/products/api.py", line 104, in get_queryset
    visible = bool(self.request.QUERY_PARAMS.get('visible', True))
  File "rest_framework/request.py", line 353, in __getattribute__
    return super(Request, self).__getattribute__(attr)
  File "rest_framework/request.py", line 380, in QUERY_PARAMS
    '`request.QUERY_PARAMS` has been deprecated in favor of `request.query_params` '

Comment 1

[Michael Cooper [:mythmon]]

PR: https://github.com/mozilla/kitsune/pull/2712

Comment 2

[Rehan Dalal (Inactive)]

Landed:
https://github.com/mozilla/kitsune/commit/11df7edf8a71c6d1199a24daac12360b8567e861

Pushed to prod by me, yesterday.