1223585 - Annotate ignoreEvent calls

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: annotate ignoreEvent

This reports something to the error console when an extension uses an event that's "implemented" using ignoreEvent.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: add ignoreEvents for ghostery

This is useful for getting Ghostery to sort of run.

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8685676 [details] [diff] [review]
annotate ignoreEvent

Review of attachment 8685676 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/ExtensionUtils.jsm
@@ +249,5 @@
>  {
>    return {
> +    addListener: function(context, callback) {
> +      let id = context.extension.id;
> +      Cu.reportError(`In add-on ${id}, attempting to use listener "${name}", which is unimplemented.`);

It would be nice to have a filename/line number, if |Components.stack.caller| returns the right thing here.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00e0498e4200
https://hg.mozilla.org/integration/mozilla-inbound/rev/be72540c9e57

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00e0498e4200
https://hg.mozilla.org/mozilla-central/rev/be72540c9e57