Annotate ignoreEvent calls

RESOLVED FIXED in Firefox 45

Status

()

Toolkit
WebExtensions: Untriaged
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(2 attachments)

Created attachment 8685676 [details] [diff] [review]
annotate ignoreEvent

This reports something to the error console when an extension uses an event that's "implemented" using ignoreEvent.
Attachment #8685676 - Flags: review?(kmaglione+bmo)
Created attachment 8685679 [details] [diff] [review]
add ignoreEvents for ghostery

This is useful for getting Ghostery to sort of run.
Attachment #8685679 - Flags: review?(kmaglione+bmo)
Attachment #8685676 - Attachment description: patch → annotate ignoreEvent
Attachment #8685679 - Attachment description: patch → add ignoreEvents for ghostery
Comment on attachment 8685676 [details] [diff] [review]
annotate ignoreEvent

Review of attachment 8685676 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/extensions/ExtensionUtils.jsm
@@ +249,5 @@
>  {
>    return {
> +    addListener: function(context, callback) {
> +      let id = context.extension.id;
> +      Cu.reportError(`In add-on ${id}, attempting to use listener "${name}", which is unimplemented.`);

It would be nice to have a filename/line number, if |Components.stack.caller| returns the right thing here.
Attachment #8685676 - Flags: review?(kmaglione+bmo) → review+
Attachment #8685679 - Flags: review?(kmaglione+bmo) → review+

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/00e0498e4200
https://hg.mozilla.org/mozilla-central/rev/be72540c9e57
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

Updated

3 years ago
Iteration: --- → 45.1 - Nov 16
You need to log in before you can comment on or make changes to this bug.