1223591 - 'mach build faster' race when generating the buildid

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

Very rarely in 'mach build faster' I hit this:

 0:00.12 /usr/bin/make -C /home/mshal/mozilla-central-git/obj-x86_64-unknown-linux-gnu -j4 -s backend.RecursiveMakeBackend
 0:00.29 /usr/bin/make -C faster -j4 -s
 0:00.86 Makefile:46: *** Variable GRE_BUILDID does not contain a value.  Stop.
 0:00.86 /home/mshal/mozilla-central-git/config/faster/rules.mk:66: recipe for target '/home/mshal/mozilla-central-git/obj-x86_64-unknown-linux-gnu/toolkit/xre/platform.ini' failed
 0:00.86 make: *** [/home/mshal/mozilla-central-git/obj-x86_64-unknown-linux-gnu/toolkit/xre/platform.ini] Error 2
 0:00.86 make: *** Waiting for unfinished jobs....

It looks like the buildid is being regenerated at the same time that toolkit/xre/Makefile is trying to read it. This can be seen more easily by adding 'rm buildid; sleep 1' in the buildid rule in objdir/config/Makefile

Comment 1

[Michael Shal [:mshal]]

Attachment: 0001-Bug-1223591-add-buildid-dependency-for-platform.ini-.patch

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/efcd4de40060

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efcd4de40060