Closed Bug 122363 Opened 23 years ago Closed 20 years ago

Implement matrix transform definition

Categories

(Core :: SVG, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: alex, Assigned: alex)

References

Details

Attachments

(1 file)

The 'transform'-attribute takes a list of 'matrix', 'translate', 'scale',
'rotate', 'skewX' and 'skewY' transformations.
We're still missing support for 'matrix'.
Attached patch patchSplinter Review
This is very weird:

The patch works fine under Linux. Under Windows however, it compiles ok, but now
whenever an nsSVGMatrix gets constructed it fails to call the base-class
constructor nsSVGValue::nsSVGValue()! This leads to mModifyNestyCount being left
unitialized and we get loads of warnings about wrongly nested modify-calls
whenever svg-content is being displayed.

Now... if in nsSVGMatrix.h in the declaration of nsSVGMatrix::Create(), I change
the name of argument 'a' to something else - e.g. '_a' - it suddenly works! The
base class constructor gets called again! 

How strange is that? Compiler error? How can these two things possibly be linked? 
Am I missing something obviuous?

Comment on attachment 66870 [details] [diff] [review]
patch

nsCRT::strtok() is more or less obsolete. Please do not use it in new code.

Please use |PL_strtok_r()| instead (which is the same function as |strtok_r()|
but it is available on all platform we support).
Attachment #66870 - Flags: needs-work+
Depends on: svgbranch
Fixed by bug 182533 landing.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: