Closed
Bug 1223644
Opened 9 years ago
Closed 8 years ago
Clean up the nsSVGClipPathFrame reference loop detection code
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
6.66 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
While writing the patch for bug 1223604 it seemed like the loop detection code could be cleaner, but this small change seemed better as a separate bug. I think this makes the consumer code clearer. We should probably make this a template class that we share among the various SVG frame classes that need to detect reference loops.
Attachment #8685756 -
Flags: review?(longsonr)
|
||
Updated•9 years ago
|
Attachment #8685756 -
Flags: review?(longsonr) → review+
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b4e10f80c070
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
|
Assignee | |
Comment 4•8 years ago
|
||
(In reply to Jonathan Watt [:jwatt] from comment #1) > We should probably make this a template class that we share among the > various SVG frame classes that need to detect reference loops. I've made this class shareable in bug 1253590. I'll file bugs to make patterns and masks use it soon.
You need to log in
before you can comment on or make changes to this bug.
Description
•