Clean up the nsSVGClipPathFrame reference loop detection code

RESOLVED FIXED in Firefox 47

Status

()

Core
SVG
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla47
Points:
---

Firefox Tracking Flags

(firefox45 affected, firefox47 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8685756 [details] [diff] [review]
patch

While writing the patch for bug 1223604 it seemed like the loop detection code could be cleaner, but this small change seemed better as a separate bug. I think this makes the consumer code clearer.

We should probably make this a template class that we share among the various SVG frame classes that need to detect reference loops.
Attachment #8685756 - Flags: review?(longsonr)
Attachment #8685756 - Flags: review?(longsonr) → review+

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b4e10f80c070
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Assignee)

Comment 4

2 years ago
(In reply to Jonathan Watt [:jwatt] from comment #1)
> We should probably make this a template class that we share among the
> various SVG frame classes that need to detect reference loops.

I've made this class shareable in bug 1253590. I'll file bugs to make patterns and masks use it soon.
You need to log in before you can comment on or make changes to this bug.