1223655 - Intermittent "###!!! ASSERTION: Track not found" in MediaEngineDefaultAudioSource::NotifyPull

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

The patch at [1] introduced a little race in MediaEngineDefaultAudioSource. In this case the audio track has ended but the stream is not finished so NotifyPull is still proxied through to the audio source.

We should keep track of when the audio track ends and tell the audio source so it can stop asking the SourceMediaStream for info on a track that does not exist.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0e38d45f7b

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: MozReview Request: Bug 1223655 - Only check for track end if track exists in MediaEngineDefaultAudioSource. r?jesup

Bug 1223655 - Only check for track end if track exists in MediaEngineDefaultAudioSource. r?jesup

Comment 2

[Andreas Pehrson [:pehrsons]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c030e265d2f6

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8685785 [details]
MozReview Request: Bug 1223655 - Only check for track end if track exists in MediaEngineDefaultAudioSource. r?jesup

https://reviewboard.mozilla.org/r/24911/#review22421

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b01d694885ed

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b01d694885ed

Comment 6

[Phil Ringnalda (:philor)]

Still seeing these, though with what feels like reduced frequency, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=2677135&repo=mozilla-central

Comment 7

[Intermittent Failures Robot]

22 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 17
* fx-team: 2
* b2g-inbound: 2
* mozilla-central: 1

Platform breakdown:
* android-4-3-armv7-api11: 8
* osx-10-10: 6
* windows7-32: 4
* osx-10-6: 3
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-11-09&endday=2015-11-15&tree=all

Comment 8

[Andreas Pehrson [:pehrsons]]

I know why - there's a mismatch between what is checked when we explicitly check for the track's existence in the StreamBuffer (FindTrackID) and what is checked by GetEndOfAppendedData().

What this means is basically that we'll assert if the track has ended but has not been removed from the StreamBuffer.

Comment 9

[Intermittent Failures Robot]

19 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 13
* b2g-inbound: 3
* fx-team: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-10: 6
* windows7-32: 5
* osx-10-6: 4
* android-4-3-armv7-api11: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-11-16&endday=2015-11-22&tree=all

Comment 10

[Intermittent Failures Robot]

19 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 12
* fx-team: 4
* mozilla-central: 3

Platform breakdown:
* osx-10-6: 12
* windows7-32: 3
* osx-10-10: 2
* windows8-64: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-11-23&endday=2015-11-29&tree=all

Comment 11

[Intermittent Failures Robot]

32 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 21
* fx-team: 7
* mozilla-central: 2
* b2g-inbound: 2

Platform breakdown:
* osx-10-6: 12
* osx-10-10: 7
* windows7-32: 6
* android-4-3-armv7-api11: 4
* windows8-64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-11-30&endday=2015-12-06&tree=all

Comment 12

[Intermittent Failures Robot]

28 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 20
* try: 3
* fx-team: 2
* b2g-inbound: 2
* mozilla-central: 1

Platform breakdown:
* osx-10-6: 13
* android-4-3-armv7-api11: 4
* windows8-64: 3
* windows7-32: 3
* osx-10-10: 3
* windowsxp: 1
* b2g-device-image: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-12-07&endday=2015-12-13&tree=all

Comment 13

[Intermittent Failures Robot]

24 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 16
* mozilla-central: 5
* fx-team: 2
* mozilla-aurora: 1

Platform breakdown:
* osx-10-6: 11
* windows7-32: 5
* android-4-3-armv7-api11: 4
* windowsxp: 1
* windows8-64: 1
* osx-10-10: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-12-14&endday=2015-12-20&tree=all

Comment 14

[Andreas Pehrson [:pehrsons]]

Attachment: Also don't check time of data end if track has ended

This should do it.

GetEndOfAppendedData gives this error when the TrackData for the provided TrackID is not found. We set the StreamBuffer's Track struct to ended at the same time as we remove that TrackData, during an MSG iteration.

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f355522e9954

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e98ed2bb333d

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f355522e9954
https://hg.mozilla.org/mozilla-central/rev/e98ed2bb333d

Comment 18

[Andreas Pehrson [:pehrsons]]

Attachment: [Aurora-45] Also don't check time of data end if track has ended

This is a merge of the two last fixes that landed on 46, rebased on top of 45. Carries r=jesup.

Approval Request Comment
[Feature/regressing bug #]: First patch of this, bug 1223655
[User impact if declined]: Intermittent oranges on debug builds
[Describe test coverage new/current, TreeHerder]: Landed on m-c, fixed the current orange per [1].
[Risks and why]: No risk. Change only applies to debug builds on a feature we only use in testing.
[String/UUID change made/needed]: None

[1] https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-12-18&tree=mozilla-inbound

Comment 19

[Intermittent Failures Robot]

9 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 5
* mozilla-central: 1
* mozilla-aurora: 1
* fx-team: 1
* b2g-inbound: 1

Platform breakdown:
* osx-10-6: 4
* osx-10-10: 2
* android-4-3-armv7-api11: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1223655&startday=2015-12-21&endday=2015-12-27&tree=all

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0786a97aee59