handlePresentation will get stuck when url protocol is not APP

RESOLVED FIXED in 2.6 S2 - 12/4

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: chunmin, Assigned: chunmin)

Tracking

unspecified
2.6 S2 - 12/4
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
This line:
https://github.com/mozilla-b2g/gaia/blob/2f1bf00b579f8183eb30d4459b2eca27503ac015/tv_apps/smart-system/js/app_window_factory.js#L127

will get error when |protocol != 'APP:'| because |config.manifest| is null
(Assignee)

Updated

3 years ago
Assignee: nobody → cchang
Created attachment 8685877 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8685877 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

Hi, Rex,
I was wondering if you could review this small patch for me.
Attachment #8685877 - Flags: review?(rexboy)
Comment on attachment 8685877 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

Looks good to me, but I'm not sure if the use case with no manifestURL works. For fling webpage we sends request through notification-manager right now.
Attachment #8685877 - Flags: review?(rexboy) → review+
Created attachment 8689454 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master
(Assignee)

Comment 5

3 years ago
Comment on attachment 8689454 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

(In reply to KM Lee [:rexboy] from comment #3)
Hi, Rex,
Sorry to bother you again. I would like to change a little bit from my previous patch. 

If we only allow those apps that have presentation permission to use presentation api, I think it's better to ignore all requests with non-app url protocol in handlePresentation.
Attachment #8689454 - Flags: review?(rexboy)
Comment on attachment 8689454 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

r+ with 1 changes required.
Please send deny message back to Gecko before return.
Attachment #8689454 - Flags: review?(rexboy) → review+
Created attachment 8690642 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8685877 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Attachment #8689454 - Attachment is obsolete: true
(Assignee)

Comment 8

3 years ago
Comment on attachment 8690642 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

Carry r+
(Assignee)

Updated

3 years ago
Attachment #8690642 - Flags: review+
Created attachment 8692906 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8690642 - Attachment is obsolete: true
(Assignee)

Comment 10

3 years ago
Comment on attachment 8692906 [details] [review]
[gaia] ChunMinChang:bug-1223677 > mozilla-b2g:master

rename summary and carry r+
Attachment #8692906 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/85834ae546bc408adba6d15629eb147ac91f8999
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.6 S2 - 12/4
You need to log in before you can comment on or make changes to this bug.