Closed Bug 1223678 Opened 6 years ago Closed 6 years ago

From unsigned web page links to signed package won't have process switch

Categories

(Firefox OS Graveyard :: Infrastructure, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Tracking Status
firefox46 --- fixed

People

(Reporter: mlien, Assigned: hchang)

References

Details

Attachments

(1 file, 2 obsolete files)

[Reproduce Steps]
1. Enable two preferences "network.http.enable-packaged-apps" and "network.http.signed-packages.enabled"
2. Set "network.http.signed-packages.trusted-root" to "http://people.mozilla.org/~mlien/"
3. Navigate to "http://people.mozilla.org/~mlien/index.html"
4. Execute command: "while true; do adb shell b2g-info; done" to monitor process
5. Choose Tab Privileged and tap UItest_Privileged package link

[Expected Result]
Should have process switch

[Actual Result]
It doesn't have process switch

[Build Information]
Build ID               20151110120047
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.111927
Firmware Date          Tue Nov 10 11:19:35 UTC 2015
Bootloader             s1

[Reproduce Rate]
100%
QA Whiteboard: [COM=NSec]
type URL from unsigned web page to signed package in Browser app -> have process switch
type URL from pinned unsigned web page to signed package         -> no process switch
link to signed package from an unsigned web page                 -> no process switch
Assignee: nobody → hchang
Depends on: 1178526
Since we choose the approach which doesn't change the parent side loadContext.originAttributes.signedPkg, we need to avoid using GetChannel*Principal in TabParent::ShouldSwitchProcess.
Attachment #8688286 - Flags: review?(kchen) → review+
Thanks Kanru :)
Keywords: checkin-needed
Hi, this failed to apply:

patching file netwerk/test/mochitests/mochitest.ini
Hunk #1 FAILED at 3
1 out of 2 hunks FAILED -- saving rejects to file netwerk/test/mochitests/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh 0001-Bug-1223678-Use-package-identifier-from-argument-to-.patch

could you rebase this patch ? Thanks!
Flags: needinfo?(hchang)
Keywords: checkin-needed
Attached patch patch (rebased) (obsolete) — Splinter Review
Attachment #8688286 - Attachment is obsolete: true
Flags: needinfo?(hchang)
Keywords: checkin-needed
this caused a bustage on all platforms and so got backedout for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=3484871&repo=b2g-inbound
Flags: needinfo?(hchang)
Oops! it seems to conflict to another patch which just landed regarding OriginAttribute refactoring...
Flags: needinfo?(hchang)
Attachment #8692369 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/643260622894
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.