1223678 - From unsigned web page links to signed package won't have process switch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Infrastructure, defect)

Description

[Mike Lien[:mlien]]

[Reproduce Steps]
1. Enable two preferences "network.http.enable-packaged-apps" and "network.http.signed-packages.enabled"
2. Set "network.http.signed-packages.trusted-root" to "http://people.mozilla.org/~mlien/"
3. Navigate to "http://people.mozilla.org/~mlien/index.html"
4. Execute command: "while true; do adb shell b2g-info; done" to monitor process
5. Choose Tab Privileged and tap UItest_Privileged package link

[Expected Result]
Should have process switch

[Actual Result]
It doesn't have process switch

[Build Information]
Build ID               20151110120047
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.111927
Firmware Date          Tue Nov 10 11:19:35 UTC 2015
Bootloader             s1

[Reproduce Rate]
100%

Comment 1

[Mike Lien[:mlien]]

type URL from unsigned web page to signed package in Browser app -> have process switch
type URL from pinned unsigned web page to signed package         -> no process switch
link to signed package from an unsigned web page                 -> no process switch

Comment 2

[Henry Chang [:hchang]]

Since we choose the approach which doesn't change the parent side loadContext.originAttributes.signedPkg, we need to avoid using GetChannel*Principal in TabParent::ShouldSwitchProcess.

Comment 3

[Henry Chang [:hchang]]

Attachment: 0001-Bug-1223678-Use-package-identifier-from-argument-to-.patch

Comment 4

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5028ee65c07

Comment 5

[Henry Chang [:hchang]]

Thanks Kanru :)

Comment 6

[Carsten Book [:Tomcat]]

Hi, this failed to apply:

patching file netwerk/test/mochitests/mochitest.ini
Hunk #1 FAILED at 3
1 out of 2 hunks FAILED -- saving rejects to file netwerk/test/mochitests/mochitest.ini.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh 0001-Bug-1223678-Use-package-identifier-from-argument-to-.patch

could you rebase this patch ? Thanks!

Comment 7

[Henry Chang [:hchang]]

Attachment: patch (rebased)

Comment 8

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f5cb895a123

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f4348b2f5c5f

Comment 10

[Carsten Book [:Tomcat]]

this caused a bustage on all platforms and so got backedout for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=3484871&repo=b2g-inbound

Comment 11

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/b2g-inbound/rev/1eae14e0fc1b

Comment 12

[Henry Chang [:hchang]]

Oops! it seems to conflict to another patch which just landed regarding OriginAttribute refactoring...

Comment 13

[Henry Chang [:hchang]]

Attachment: Patch (rebased and fixed compile error)

Comment 14

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=843e17eee5eb&selectedJob=14684721

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/643260622894

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/643260622894