1223683 - [Email]While canceling the change of the signature, the "Cancel" button appears as a rectangular button similar to other options.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
[Aries KK v2.5&2.6][Flame KK v2.5&2.6][Email]After changing the signature and tapping the Back icon, the "Cancel" button is not displayed as an oval button, and it appears as a rectangular button similar to other options in the menu.
Found at: 22:50
Attach: Flame_v2.6.png and logcat_2250.txt.

[2.Testing Steps]: 
1. Launch Email and sign in an account.
2. Tap the drawer and tap "Settings" icon.
3. Select the account and tap "Sent Using Firefox OS" button.
4. Change the signature and then tap "Back" icon.

[3.Expected Result]: 
4. The "Cancel" button should appear as an oval button.

[4.Actual Result]: 
4. The Cancel button will appear as a rectangular button similar to other options in the menu, with its text left-aligned and a blank space below it at the bottom of the screen.

[5.Reproduction build]: 
Device: Flame KK 2.2  512mb (unaffected) 
Build ID               20151110032503
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ac5fce5a78e5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151110.064719
Firmware Date          Tue Nov 10 06:47:30 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5  512mb (affected)
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master)(affected)
Build ID               20151110150205
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151110.182433
Firmware Date          Tue Nov 10 18:24:47 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (affected)
Build ID               20151110094357
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.090331
Firmware Date          Tue Nov 10 09:03:39 UTC 2015
Bootloader             s1

Device: Aries KK 2.6 (master)(affected)
Build ID               20151110120047
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.111927
Firmware Date          Tue Nov 10 11:19:35 UTC 2015
Bootloader             s1


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: Flame_v2.6.png

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: logcat_2250.txt

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] jrburke:bug1223683-email-draft-cancel > mozilla-b2g:master

Comment 4

[James Burke [:jrburke]]

Comment on attachment 8686696 [details] [review]
[gaia] jrburke:bug1223683-email-draft-cancel > mozilla-b2g:master

Shared styles changed, the span wrapping matches what was done for other dialogs like this, fixes the issue. Just an HTML change.

Comment 5

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/c2841a8e0cd69c6c9b2293b91b6c7f9595e26c9d

Comment 6

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.6 by the STR in comment 0.

Actual results: When canceling the change of the signature, the "Cancel" button shows normally.
See attachment: verified_Flame_v2.6.png
Reproduce rate: 0/10

Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151115150212
Gaia Revision          e8c15ae4e5324a210000ee0a869a962aa542009f
Gaia Date              2015-11-13 00:10:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7cd2d806bd069c0260ff73f023ac85f892b863bf
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151115.184416
Firmware Date          Sun Nov 15 18:44:31 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Note: 
I can't verify Aries KK v2.6(master) because there is no the latest AriesKK v2.6 build now, but I will verify it once it has the latest AriesKK v2.6 build.

Comment 7

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.6.png

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Aries KK 2.6 by the STR in comment 0.

Actual results: The "Cancel" button shows normally in email settings.
See above attachment: "verified_Flame_v2.6.png"
Reproduce rate: 0/10

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151118150439
Gaia Revision          cba7e4b86361af31b153cfebaf99900e0b860f7b
Gaia Date              2015-11-18 09:45:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1d6155d7e6c91fa5ec1ef6927f3d3a044187896d
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151118.142334
Firmware Date          Wed Nov 18 14:23:42 UTC 2015
Bootloader             s1