no way to fix things when MozReview gets patch identity wrong in revised series

RESOLVED INVALID

Status

defect
RESOLVED INVALID
4 years ago
7 months ago

People

(Reporter: dbaron, Unassigned)

Tracking

Details

A revision of the patch series in https://reviewboard.mozilla.org/r/24367/ led to MozReview misidentifying which patch was which.  Thus a large number of comments that were actually made on what is now https://reviewboard.mozilla.org/r/24415/ (although it may change again) now show up as comments on https://reviewboard.mozilla.org/r/24373/ .  (They show up for me as "Nov. 10, 2015, 9:47 a.m." but I can't find a way to link to them.)

There's no way to fix this, and it makes the state of the review incredibly confusing.
Oh, and the direct evidence of the patch identity confusion here is bug 686281 comment 134 and bug 686281 comment 135.  The first half of the comments were bug 686281 comment 131, and the continuation was bug 686281 comment 162.
Sounds like some commit reordering without the evolve extension enabled... flagging gps to confirm.
Flags: needinfo?(gps)
I believe CJ was pushing to mozreview from git.
The proper way to fix this is to make the commit mapping more robust. I have patches in bug 1243486 that start laying the ground work for this. I'll leave this bug open to track making sure whatever scenario happened in this bug report can be verified as working when the new commit mapping mechanism is deployed.
Blocks: 1243483
Flags: needinfo?(gps)
Product: Developer Services → MozReview
Component: General → Review Board: Extension

Comment 5

7 months ago
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.