Closed
Bug 1223717
Opened 9 years ago
Closed 9 years ago
Use chrome override for privatebrowsing-mask-tabstrip-XPVista7.png and privatebrowsing-mask-titlebar-XPVista7.png
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: dao, Assigned: rn10950, Mentored)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
|
4.61 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1216955 +++ Instead of this media query: http://hg.mozilla.org/mozilla-central/annotate/cc473fe5dc51/browser/themes/windows/browser.css#l2709 ... we should add these files to the overrides here: http://hg.mozilla.org/mozilla-central/annotate/cc473fe5dc51/browser/themes/windows/jar.mn#l322
|
Reporter | |
Comment 4•9 years ago
|
||
If you have access to Windows 7, Vista or XP, yes. Just open a private window and check that these images are used in the title bar and the tab strip (when in fullscreen mode): http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-titlebar-XPVista7.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-tabstrip-XPVista7.png rather than these images: http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-titlebar.png http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-tabstrip.png
This was created and tested with Windows 7 (classic theme) and it appears to be working as intended.
Attachment #8690368 -
Flags: review?(dao)
|
|
Reporter | |
Comment 6•9 years ago
|
||
Comment on attachment 8690368 [details] [diff] [review] patch 1 Looks good!
Attachment #8690368 -
Flags: review?(dao) → review+
|
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → rn10950
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/92a091e32241
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in
before you can comment on or make changes to this bug.
Description
•