1223717 - Use chrome override for privatebrowsing-mask-tabstrip-XPVista7.png and privatebrowsing-mask-titlebar-XPVista7.png

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1216955 +++

Instead of this media query:

http://hg.mozilla.org/mozilla-central/annotate/cc473fe5dc51/browser/themes/windows/browser.css#l2709

... we should add these files to the overrides here:

http://hg.mozilla.org/mozilla-central/annotate/cc473fe5dc51/browser/themes/windows/jar.mn#l322

Comment 1

[rn10950]

I can probably take this.

Comment 2

[Dão Gottwald [:dao]]

Sure, please give it a shot.

Comment 3

[rn10950]

Is there a way to verify that it worked?

Comment 4

[Dão Gottwald [:dao]]

If you have access to Windows 7, Vista or XP, yes. Just open a private window and check that these images are used in the title bar and the tab strip (when in fullscreen mode):

http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-titlebar-XPVista7.png
http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-tabstrip-XPVista7.png

rather than these images:

http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-titlebar.png
http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/privatebrowsing-mask-tabstrip.png

Comment 5

[rn10950]

Attachment: patch 1

This was created and tested with Windows 7 (classic theme) and it appears to be working as intended.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8690368 [details] [diff] [review]
patch 1

Looks good!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/92a091e32241

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92a091e32241