1223745 - use GENERATED_FILES to generate headers in toolkit/mozapps/update/updater/Makefile.in

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

This looks like a fairly straightforward application of GENERATED_FILES:
https://dxr.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23/toolkit/mozapps/update/updater/Makefile.in#41

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1223745 - Move generate headers in toolkit/mozapps/update/updater/Makefile.in to GENERATED_FILES. r=glandium

Bug 1223745 - Move generate headers in toolkit/mozapps/update/updater/Makefile.in to GENERATED_FILES. r=glandium

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8696984 [details]
MozReview Request: Bug 1223745 - Move generate headers in toolkit/mozapps/update/updater/Makefile.in to GENERATED_FILES. r=glandium

https://reviewboard.mozilla.org/r/27475/#review25019

::: toolkit/mozapps/update/updater/gen_cert_header.py:16
(Diff revision 1)
> +  array_name = out_fh.name.replace('.h', 'Data')

Maybe:
  assert out_fh.name.endswith('.h')
  array_name = out_fh.name[:-2] + 'Data'
?

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8696984 [details]
MozReview Request: Bug 1223745 - Move generate headers in toolkit/mozapps/update/updater/Makefile.in to GENERATED_FILES. r=glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27475/diff/1-2/

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d265db3920de

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d265db3920de