"scrollbars.css" takes you to a differently named file and is missing an "all results" bubble

NEW
Unassigned

Status

Webtools
DXR
3 years ago
2 years ago

People

(Reporter: erik, Unassigned)

Tracking

Trunk

Firefox Tracking Flags

(firefox45 affected)

Details

(Reporter)

Description

3 years ago
Type scrollbars.css in the query field and hit return.

You should probably get a results list. Surprisingly you end up at https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/xulscrollbars.css. Perhaps that's not such a bad thing. But at the very least, there should be a "That was a direct result. Show _all results_ if you want." bubble.
The search hits a direct result, scrollbars.css. However scrollbars.css is a symlink to xulscrollbars.css, so it immediately redirects.

The direct search returns https://dxr.mozilla.org/mozilla-central/source/obj-x86_64-unknown-linux-gnu/dist/bin/chrome/toolkit/skin/classic/global/scrollbars.css?from=scrollbars.css.

Because of https://github.com/mozilla/dxr/pull/458, we therefore redirect to https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/xulscrollbars.css.

So a couple of ways to go about this are to 1) propogate the symlink information into the redirect as another parameter so we can pop up a bubble about it, or 2) disallow direct search to find symlinks.
Flags: needinfo?(erik)
(Reporter)

Comment 2

2 years ago
I tend toward #1. It would be surprising as a user to not be able to search for symlink names, and putting an explanation of the symlink traversal in the bubble mitigates user surprise at the filename differing. We should also preserve any "This is a direct result" wording (e.g. by propagating the from= param) during symlink traversals.
Flags: needinfo?(erik)
You need to log in before you can comment on or make changes to this bug.