Eliminate MOZ_GUARD_OBJECT in favor of MOZ_RAII

NEW
Unassigned

Status

Firefox Build System
Source Code Analysis
3 years ago
2 months ago

People

(Reporter: Nika, Unassigned)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
The MOZ_RAII static analysis was introduced in bug 1201190, but MOZ_GUARD_OBJECT was kept around, as the analysis isn't run on windows. once bug 1042132 is fixed, this shouldn't be a problem, so we can remove MOZ_GUARD_OBJECT completely.
(Reporter)

Updated

2 years ago
Blocks: 972135

Updated

2 years ago
Depends on: 1299509
No longer depends on: 1042132

Comment 1

5 months ago
This work is up for grabs now that we have Windows st-an builds, right? Are there any other barriers -- Android maybe?
Flags: needinfo?(nika)
(Reporter)

Comment 2

5 months ago
I don't think we run the clang static analysis on android builds, but that might be it.

We might be able to get rid of MOZ_GUARD_OBJECT though now that we at least have coverage for all desktop platforms. I'm not sure.
Flags: needinfo?(nika)
njn and I are getting Android static analysis up and running this quarter.  I think we should avoid ditching guard objects until we have static analysis running on all of our tier1 platforms.

Updated

3 months ago
Product: Core → Firefox Build System

Updated

2 months ago
Depends on: 1428158
You need to log in before you can comment on or make changes to this bug.