Closed Bug 1223974 Opened 10 years ago Closed 8 years ago

Remove duplicate clear data from Top Sites in refresh call and wrap Delete/Insert into a transaction

Categories

(Firefox for iOS :: Data Storage, defect)

Product:
Firefox for iOS
Component:
Data Storage
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: sleroux, Unassigned, Mentored)

Details

(Keywords: perf)

Whenever we call refreshTopSites we first call clear then update but the update call also calls clear [1]. We should remove the first clear and wrap the update DB calls in a transaction. [1] https://github.com/mozilla/firefox-ios/blob/master/Storage/SQL/SQLiteHistory.swift#L292
Mentor: sleroux
tracking-fxios: ? → +
We use the paneldataobserver which fixes this now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.