1224031 - [fxos-device-service] Fix intermittent bustage from /files implementation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Infrastructure, defect)

Description

[:Eli Perelman]

Ever since the implementation of /files landed, Travis has been having intermittent failures. Investigate and fix.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/fxos-device-service/pull/26

So in trying to root cause this, I was never able to replicate locally, but would continuously get intermittents from Travis. Iterating on this patch, the current implementation was tested 6 times through Travis with no failures, which is something I could not achieve while testing any of my other patches. I'd like to say this one resolves the issue.

I believe the problem stemmed from the usage of the `adb shell cat` command, but I can't say for sure. I've refactored out our usage of the cats, in favor of doing an adb pull to a tempdir, and then streaming the file to the client with some decent error checking.

I've also cleaned this up into a middleware response method, available as `res.sendFromDevice(remotePath)`. It cleans up code in a few places, which is a nice side effect. Let me know your thoughts.

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8686317 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/fxos-device-service/pull/26

r+ with nits. Overall looks great though thanks!

Comment 3

[:Eli Perelman]

In master: https://github.com/mozilla-b2g/fxos-device-service/commit/6fcbbcdf444e2d96b9df518e81b76b3fff0e0be3

Thanks!