Closed Bug 1224102 Opened 4 years ago Closed 4 years ago

reduce the size of the final FFT convolution stage if possible

Categories

(Core :: Web Audio, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(1 file)

The last FFT convolution stage can often be smaller due to covering a shorter
portion of the impulse-response buffer.

A stage of the same size but with half the FFT size needs to perform the FFT
twice as often but still theoretically wins by a log(n) reduction.  That may
not be much, but I expect there to also be improvements in cache hits through
iterating over smaller buffers.

Reducing the FFT size can also improve accuracy, including reducing the period
of influence of any numerical errors or non-finite bad values in the input
(see bug 1223520).
Attachment #8686438 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/d3b584b54bb9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Kind of tested by https://hg.mozilla.org/mozilla-central/rev/51287ab3d66a
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.