Closed Bug 1224191 Opened 9 years ago Closed 9 years ago

The incoming call container has a hole at the bottom

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.5 verified, b2g-master verified)

VERIFIED FIXED
Tracking Status
b2g-v2.5 --- verified
b2g-master --- verified

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

(Keywords: regression)

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1212329 +++

Bug 1212329 is causing this, unfortunately it's something I hadn't noticed at the time of reviewing that patch.

[Blocking Requested - why for this release]: Visual regression to a common scenario
Can we get a screen shot?
Attached image Screenshot of the issue
Here's a screenshot of the issue. I'm looking at the CSS changes but it's not obvious what's causing this.
OK, figured it out, patch incoming.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8686658 [details] [review]
[gaia] gabrielesvelto:bug-1224191-fix-incoming-call-container > mozilla-b2g:master

One-line fix, we removed a global CSS rule that did affect *all* elements and this was causing the problem. Since it was global it was unclear what it was affecting, that should teach us never to use those.
Attachment #8686658 - Flags: review?(thills)
Comment on attachment 8686658 [details] [review]
[gaia] gabrielesvelto:bug-1224191-fix-incoming-call-container > mozilla-b2g:master

Hi Gabriele,

LGTM.  I can see how this fixes the problem.

Thanks,

-tamara
Attachment #8686658 - Flags: review?(thills) → review+
Merged to gaia/master 3c863666f23e598530062a238f1703d550484614

https://github.com/mozilla-b2g/gaia/commit/3c863666f23e598530062a238f1703d550484614
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Clearing the blocking flag, will request approval for the patch directly.
blocking-b2g: 2.5? → ---
Comment on attachment 8686658 [details] [review]
[gaia] gabrielesvelto:bug-1224191-fix-incoming-call-container > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1212329
[User impact] if declined: Visual glitch while receiving a second incoming call, the bottom part of the element displaying the new call becomes transparent. See the attached screenshot (attachment 8686643 [details])
[Testing completed]: Tested on two different devices and in the emulator
[Risk to taking this patch] (and alternatives if risky): None, this is a one-line CSS change that reinstates a missing rule
[String changes made]: None
Attachment #8686658 - Flags: approval-gaia-v2.5?
Comment on attachment 8686658 [details] [review]
[gaia] gabrielesvelto:bug-1224191-fix-incoming-call-container > mozilla-b2g:master

Minor regression fix. Approved for 2.5 uplift. 

Thanks
Attachment #8686658 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Cherry picked to gaia/v2.5 311e0b815f2640b308ffdca54dd8c0a6739d6494

https://github.com/mozilla-b2g/gaia/commit/311e0b815f2640b308ffdca54dd8c0a6739d6494
This bug has been verified as "pass" on the latest build of Flame v2.5&master and Aries KK v2.5&master.

STR:
1.Make a call.
2.Incoming call arrives.

Actual results: The incoming call container has no a hole at the bottom.
See attachment: verified_Flame_v2.5.png
Reproduce rate: 0/10


Device: Flame 2.5 512mb (Pass)
Build ID               20151124190915
Gaia Revision          7726bfd621d709fa2d179704a44aebc1c309c296
Gaia Date              2015-11-24 15:12:43
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/124375497b14260515e8d2af9c8507a9995b7a47
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.181847
Firmware Date          Tue Nov 24 18:18:56 UTC 2015
Bootloader             L1TC000118D0
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame master 512mb (Pass) 
Build ID               20151124013632
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005539
Firmware Date          Tue Nov 24 00:55:49 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5 (Pass)  
Build ID               20151123164502
Gaia Revision          5839f17dedc757947c9531dc0d66c3c49119f5ea
Gaia Date              2015-11-20 22:47:58
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3a45ca93dd447e046baa2c7590f60ae008e438f8
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151123.155500
Firmware Date          Mon Nov 23 15:55:07 UTC 2015
Bootloader             s1

Device: Aries KK master (Pass) 
Build ID               20151124014704
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005529
Firmware Date          Tue Nov 24 00:55:36 UTC 2015
Bootloader             s1
Status: RESOLVED → VERIFIED
QA Whiteboard: [MGSEI-Triage+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: