Open Bug 1224206 Opened 4 years ago Updated 2 years ago

[gtk3] Double click on empty space on tab bar does not open new tab with Mozilla default theme and other themes

Categories

(Core :: Widget: Gtk, defect, P2)

defect

Tracking

()

People

(Reporter: jhorak, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: tpi:+)

Click on empty space on tab bar starts to drag the window instead of receiving double click event and opening a new tab in some GTK3 themes.

It happens when GTK3 theme contains:
.menubar {
 -GtkWidget-window-dragging: true;
}

In this case <toolbar id="TabsToolbar"> use:
-moz-binding: chrome://browser/content/customizableui/toolbar.xml#toolbar-drag
because <toolbar id="TabsToolbar"> also has:
-moz-appearance: menubar
Using menubar appearance to tab toolbar has been introduced by fix in bug 580970.

I'm able to reproduce it with Bluebird, Albatross, Clearlooks.

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1226659
Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0
I can reproduce this bug with Mozilla's default theme, but it works with the developer edition theme.
Summary: [gtk3] Double click on empty space on tab bar does not open new tab for some themes → [gtk3] Double click on empty space on tab bar does not open new tab with Mozilla default theme and other themes
Blocks: gtk3
I have the same bug on the Archlinux build (built with gtk3 since 43.0) with the theme Adwaita.
Duplicate of this bug: 1263924
Jan, the workaround you posted downstream no longer works for me since upgrading from Fedora 22 to 24 -- any ideas about why that might be or another solution?
Flags: needinfo?(jhorak)
Same problem here, first I thought it's new kde5 (plasma) problem, but I see it's probably Firefox problem.
Workaround/Solution?: in about:config set `extensions.tabmix.tabbar.dblclick_changesize` to `false`.
Sorry, my previous comment was solution only for addon tabmix plus, which also suffers the same problem as the default tabbar. Also it was wrong, the correct option is called `extensions.tabmix.tabbar.click_dragwindow`.
For the record, I'm not using kde/plasma, but i3. At the time, reverting to a previous firefox version didn't exhibit the regression, confirming that it's not an issue caused by some external factor.

Double clicking on the tab-tab simply does nothing any more.
(In reply to gruobbuashua from comment #4)
> Jan, the workaround you posted downstream no longer works for me since
> upgrading from Fedora 22 to 24 -- any ideas about why that might be or
> another solution?

Updated workaround is there: https://bugzilla.redhat.com/show_bug.cgi?id=1226659#c10
Flags: needinfo?(jhorak)
Priority: -- → P2
Whiteboard: tpi:+
Jan, the workaround you posted downstream stopped working again in Firefox 57 (or possibly before) -- do you know what adjustment is needed to get this working again? thanks in advance :-)
Flags: needinfo?(jhorak)
You need to log in before you can comment on or make changes to this bug.